From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVrGq-0001Mn-K4 for qemu-devel@nongnu.org; Thu, 13 Jul 2017 23:28:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVrGn-0005rI-GQ for qemu-devel@nongnu.org; Thu, 13 Jul 2017 23:28:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54378) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dVrGn-0005py-9Z for qemu-devel@nongnu.org; Thu, 13 Jul 2017 23:27:57 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 398B210C96 for ; Fri, 14 Jul 2017 03:27:56 +0000 (UTC) Date: Fri, 14 Jul 2017 11:27:53 +0800 From: Peter Xu Message-ID: <20170714032753.GF27284@pxdev.xzpeter.org> References: <20170713115649.11853-1-dgilbert@redhat.com> <20170713115649.11853-3-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170713115649.11853-3-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 2/5] migration: Close file on failed migration load List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, quintela@redhat.com, lvivier@redhat.com On Thu, Jul 13, 2017 at 12:56:46PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Closing the file before exit on a failure allows > the source to cleanup better, especially with RDMA. > > Partial fix for https://bugs.launchpad.net/qemu/+bug/1545052 > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Peter Xu