From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Juan Quintela <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] migration: export cap/params to qdev props
Date: Fri, 14 Jul 2017 13:01:10 -0300 [thread overview]
Message-ID: <20170714160110.GF6020@localhost.localdomain> (raw)
In-Reply-To: <20170714050423.GM27284@pxdev.xzpeter.org>
On Fri, Jul 14, 2017 at 01:04:23PM +0800, Peter Xu wrote:
> On Wed, Jul 12, 2017 at 04:05:58PM -0300, Eduardo Habkost wrote:
> > On Wed, Jul 12, 2017 at 02:53:40PM +0800, Peter Xu wrote:
> > [...]
> > > These properties should only be used for debugging/testing purpose,
> > > and we should not guarantee any interface compatibility for them (just
> > > like HMP).
> >
> > If we don't guarantee compatibility, the property names need to
> > be prefixed with "x-".
>
> Indeed. Sorry I missed that.
>
> But I'd say it is slightly awkward to add "x-" for all these (for me,
> "x-" means more like "this is not stable and experimental, use it
> carefully", while this does not suite for this series). Maybe I can
> just remove this sentence in commit log (I think I am just a little
> bit frightened by the compatibility problems)...
"x-" in property names doesn't mean "experimental", but just "not
part of the stable interface". If you have the tiniest doubt
about command-line compatibility, I think it won't hurt to use
"x-".
--
Eduardo
next prev parent reply other threads:[~2017-07-14 16:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 6:53 [Qemu-devel] [PATCH 0/3] migration: export cap/params to qdev props Peter Xu
2017-07-12 6:53 ` [Qemu-devel] [PATCH 1/3] qdev: provide DEFINE_PROP_INT64() Peter Xu
2017-07-13 16:05 ` Marc-André Lureau
2017-07-14 3:06 ` Peter Xu
2017-07-12 6:53 ` [Qemu-devel] [PATCH 2/3] migration: export parameters to props Peter Xu
2017-07-12 18:49 ` Dr. David Alan Gilbert
2017-07-12 6:53 ` [Qemu-devel] [PATCH 3/3] migration: export capabilities " Peter Xu
2017-07-12 18:59 ` Dr. David Alan Gilbert
2017-07-12 19:02 ` [Qemu-devel] [PATCH 0/3] migration: export cap/params to qdev props Dr. David Alan Gilbert
2017-07-14 4:23 ` Peter Xu
2017-07-14 15:57 ` Eduardo Habkost
2017-07-17 3:25 ` Peter Xu
2017-07-12 19:05 ` Eduardo Habkost
2017-07-14 5:04 ` Peter Xu
2017-07-14 16:01 ` Eduardo Habkost [this message]
2017-07-14 16:32 ` Dr. David Alan Gilbert
2017-07-17 3:06 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714160110.GF6020@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).