From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWE5R-0001SH-FD for qemu-devel@nongnu.org; Fri, 14 Jul 2017 23:49:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWE5M-0001it-Q3 for qemu-devel@nongnu.org; Fri, 14 Jul 2017 23:49:45 -0400 Date: Sat, 15 Jul 2017 12:42:46 +1000 From: David Gibson Message-ID: <20170715024246.GI17539@umbus.fritz.box> References: <20170712055317.26225-1-david@gibson.dropbear.id.au> <8b7aefb2-66e3-bc2b-ce13-11b130c85ce4@linux.vnet.ibm.com> <20170713005740.GR4083@umbus.fritz.box> <901df6de-ffc8-1b01-3f8d-37e30f852799@linux.vnet.ibm.com> <20170714065316.GB17539@umbus.fritz.box> <9308b227-ed59-caf0-eb41-608d37b8ed30@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oxV4ZoPwBLqAyY+a" Content-Disposition: inline In-Reply-To: <9308b227-ed59-caf0-eb41-608d37b8ed30@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 0/8] spapr: DRC cleanups (part VI) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Daniel Henrique Barboza Cc: lvivier@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, groug@kaod.org, qemu-ppc@nongnu.org, sjitindarsingh@gmail.com, bharata@linux.vnet.ibm.com --oxV4ZoPwBLqAyY+a Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 14, 2017 at 10:50:06AM -0300, Daniel Henrique Barboza wrote: >=20 >=20 > On 07/14/2017 03:53 AM, David Gibson wrote: > > On Thu, Jul 13, 2017 at 07:13:23AM -0300, Daniel Henrique Barboza wrote: > > >=20 > > > On 07/12/2017 09:57 PM, David Gibson wrote: > > > > On Wed, Jul 12, 2017 at 10:48:38AM -0300, Daniel Henrique Barboza w= rote: > > > > > The dreaded Libvirt hotplug-migrate-hotunplug scenario is working= nicely. > > > > Good to hear. > > > >=20 > > > > > device_add when the machine is in RUN_STATE_PRELAUNCH (-S) still = doesn't > > > > > work but it is expected - as discussed in "[RFC drcVI PATCH] spap= r: reset > > > > > DRCs > > > > > on migration pre_load=E2=80=8B", this scenario can't be fixed sol= ely by this DRC > > > > > cleanup. > > > > Hmm.. what's the exact test case you're using here? The prelaunch > > > > case I tried _did_ work (queueing the event during prelaunch, then > > > > completing the hotplug sequence once the guest had booted). > > > This is the test case: > > >=20 > > > sudo ./qemu-system-ppc64 -name migrate_qemu -boot strict=3Don --enabl= e-kvm > > > -device nec-usb-xhci,id=3Dusb,bus=3Dpci.0,addr=3D0xf -device > > > spapr-vscsi,id=3Dscsi0,reg=3D0x2000 -smp 1,maxcpus=3D4,sockets=3D4,co= res=3D1,threads=3D1 > > > --machine pseries,accel=3Dkvm,usb=3Doff,dump-guest-core=3Doff -m > > > 4G,slots=3D32,maxmem=3D32G -drive file=3D/home/danielhb/vm_imgs/ubunt= u1704.qcow2,format=3Dqcow2,if=3Dnone,id=3Ddrive-virtio-disk0,cache=3Dnone > > > -device virtio-blk-pci,scsi=3Doff,bus=3Dpci.0,addr=3D0x2,drive=3Ddriv= e-virtio-disk0,id=3Dvirtio-disk0,bootindex=3D1 > > > -nographic -S > > > QEMU 2.9.50 monitor - type 'help' for more information > > > (qemu) > > > (qemu) device_add host-spapr-cpu-core,id=3Dcore1,core-id=3D1 > > > (qemu) cont > > >=20 > > > (...) > > >=20 > > > After OS boots: > > >=20 > > > danielhb@ubuntu1704:~$ lscpu > > > Architecture: ppc64le > > > Byte Order: Little Endian > > > CPU(s): 1 > > > On-line CPU(s) list: 0 > > > Thread(s) per core: 1 > > > Core(s) per socket: 1 > > > Socket(s): 1 > > > NUMA node(s): 1 > > > Model: 2.1 (pvr 004b 0201) > > > Model name: POWER8E (raw), altivec supported > > > Hypervisor vendor: horizontal > > > Virtualization type: full > > > L1d cache: 64K > > > L1i cache: 32K > > > NUMA node0 CPU(s): 0 > > > danielhb@ubuntu1704:~$ (qemu) > > > (qemu) info cpus > > > * CPU #0: nip=3D0xc0000000000a3e0c thread_id=3D6134 > > > CPU #1: nip=3D0x0000000000000000 (halted) thread_id=3D6163 > > > (qemu) info hotpluggable-cpus > > > Hotpluggable CPUs: > > > type: "host-spapr-cpu-core" > > > vcpus_count: "1" > > > CPUInstance Properties: > > > core-id: "3" > > > type: "host-spapr-cpu-core" > > > vcpus_count: "1" > > > CPUInstance Properties: > > > core-id: "2" > > > type: "host-spapr-cpu-core" > > > vcpus_count: "1" > > > qom_path: "/machine/peripheral/core1" > > > CPUInstance Properties: > > > core-id: "1" > > > type: "host-spapr-cpu-core" > > > vcpus_count: "1" > > > qom_path: "/machine/unattached/device[0]" > > > CPUInstance Properties: > > > core-id: "0" > > > (qemu) > > Huh. I tried basically the same thing, and I get the second cpu once > > the OS is booted. My first guess would be that the difference is in > > the guest (mine is RHEL 7.3). Have you double checked that rtas_errd > > and drmgr are present in your guest? >=20 > Yeah the guest has drmgr and rtas_errd running. As you said, there might = be > something different in the guests that explains why yours work and mine > doesn't. > Coupling that with the fact that this is not a common usage, I believe we > can leave it as a FYI/reminder if we need to revisit this issue in the > future. I concur. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --oxV4ZoPwBLqAyY+a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAllpgSYACgkQbDjKyiDZ s5JSoRAA1kgRYUHHFGQPT/rZjA2oZaS18log3m2jV9pES1Me1cAXsCgzLAiWYQdR VTUfcvTkrBDVu8zjdmLFKgpZDUdFnpQcmT1Uczi5HX2r1LIQjNIKuexjZwzWWnf4 tjbEbM4tdtAqAckg11mUksWM/RWn3rpHdDr51wrJ1rMp0ljad8Y60QjrngJl4fRQ 3HAph62Eqaa+zq5YD2u92up7molXdpt9/seeCfeONq00uPsYwE3shPkzibWrtcHP 591GA4C7SOPOg14WkhMvzko4gjzOw03OdckJpl1vvOyZA9wsAKkFhEI1i+0ouPqL kY5eMj7bP3AFQyOqJz5q7xBTqQkUL8P7ahUin3fJXCVaCRbnmFuYioZjrjvUjsA9 gbjcjlaE2WdTrRRcNiWvvxMnbuob9BrRl0Me3B/YawJcfFHM44/xilI6te3FOkaj 1RvSsXAKh1KFdeAD3tfzZr99uFxmLhwmSE08m1K/Zs7xx84oh4c9tUgYl434HKtM uswjAyjSiocUI2tPrVHFm6DY3cI+U+2zSyhJVccNOUYicXsVj8Q7XD+Njrn4m5i5 oGAy0YwexuNbCBpb9EXuagBfGCt7FCO3b39hcdY0D1phnSAicF09oC0MDaSwkmvy rg2xEMzFwHDuU/3itG5j94OrVEvM48BHhdHyXoH6jhOoZEa0l9k= =OtjC -----END PGP SIGNATURE----- --oxV4ZoPwBLqAyY+a--