Re: [Qemu-devel] [PULL 00/18] ppc-for-2.10 queue 20170714

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

On Sat, Jul 15, 2017 at 08:45:13AM +0100, Peter Maydell wrote:
> On 15 July 2017 at 03:42, David Gibson <david@gibson.dropbear.id.au> wrote:
> > On Fri, Jul 14, 2017 at 04:13:05PM +0100, Peter Maydell wrote:
> >> Hi. I'm afraid this fails to build on the w32 compiler:
> >>   CC      ppc64-softmmu/hw/ppc/spapr.o
> >> /home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c: In function
> >> ‘spapr_get_resize_hpt’:
> >> /home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c:2642:1: error:
> >> control reaches end of non-void functio
> >> n [-Werror=return-type]
> >>  }
> >
> > Drat.  Is there an easy way to test compile for w32?
> 
> I have a cross-compiler set up on an Ubuntu host; you
> can do it on Redhat hosts too; instructions on the wiki
> somewhere I think.

Ah, thanks, found them.

> In this case I think you're either getting caught by the
> age of the compiler or because this set of w32 headers
> have a bug where assert() doesn't get marked as fatal
> somehow, so it might or might not manifest on other
> w32 cross build setups.

Ah, right.

> > Yes, seems good.  Should I resend, or will you adjust in place?
> 
> You'll need to resend -- I can't modify signed pull reqs.

Ah, yes of course.

I've also realised one of the patches breaks make check on Travis OSX
builds for reasons I haven't quite fathomed yet.  Investigating.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]