qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org,
	stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 08/11] qed: introduce bdrv_qed_init_state
Date: Mon, 17 Jul 2017 11:36:08 +0800	[thread overview]
Message-ID: <20170717033608.GC22872@lemon> (raw)
In-Reply-To: <20170629132749.997-9-pbonzini@redhat.com>

On Thu, 06/29 15:27, Paolo Bonzini wrote:
> diff --git a/block/qed.c b/block/qed.c
> index db390efdbd..8228a50f68 100644
> --- a/block/qed.c
> +++ b/block/qed.c
> @@ -363,6 +363,15 @@ static void coroutine_fn bdrv_qed_co_drain(BlockDriverState *bs)
>      }
>  }
>  
> +static void bdrv_qed_init_state(BlockDriverState *bs)
> +{
> +    BDRVQEDState *s = bs->opaque;

This line should be in the next patch, to keep the compiler happy
(-Wunused-variable). I'll fix it when sending pull request.

> +
> +    memset(s, 0, sizeof(BDRVQEDState));
> +    s->bs = bs;
> +    qemu_co_queue_init(&s->allocating_write_reqs);
> +}
> +

Fam

  parent reply	other threads:[~2017-07-17  3:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 13:27 [Qemu-devel] [PATCH v2 00/11] Block layer thread-safety, part 2 Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 01/11] qcow2: call CoQueue APIs under CoMutex Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 02/11] coroutine-lock: add qemu_co_rwlock_downgrade and qemu_co_rwlock_upgrade Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 03/11] vdi: make it thread-safe Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 04/11] vpc: " Paolo Bonzini
2017-07-10 11:32   ` Fam Zheng
2017-06-29 13:27 ` [Qemu-devel] [PATCH 05/11] vvfat: " Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 06/11] qed: move tail of qed_aio_write_main to qed_aio_write_{cow, alloc} Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 07/11] block: invoke .bdrv_drain callback in coroutine context and from AioContext Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 08/11] qed: introduce bdrv_qed_init_state Paolo Bonzini
2017-06-29 15:26   ` Eric Blake
2017-07-17  3:36   ` Fam Zheng [this message]
2017-06-29 13:27 ` [Qemu-devel] [PATCH 09/11] qed: protect table cache with CoMutex Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 10/11] sheepdog: add queue_lock Paolo Bonzini
2017-06-29 13:27 ` [Qemu-devel] [PATCH 11/11] ssh: support I/O from any AioContext Paolo Bonzini
2017-07-05 21:57 ` [Qemu-devel] [Qemu-block] [PATCH v2 00/11] Block layer thread-safety, part 2 Paolo Bonzini
2017-07-06 23:50 ` [Qemu-devel] " no-reply
2017-07-07  0:05   ` Fam Zheng
2017-07-10 12:18 ` Stefan Hajnoczi
2017-07-10 13:09 ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170717033608.GC22872@lemon \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).