qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, Kevin Wolf <kwolf@redhat.com>,
	Max Reitz <mreitz@redhat.com>,
	"open list:Block layer core" <qemu-block@nongnu.org>
Subject: [Qemu-devel] [PATCH 5/5] blockdev: Use simpler QAPI_TO_QOBJECT()
Date: Mon, 17 Jul 2017 10:56:32 -0500	[thread overview]
Message-ID: <20170717155632.12754-6-eblake@redhat.com> (raw)
In-Reply-To: <20170717155632.12754-1-eblake@redhat.com>

Use the new macro to avoid some boilerplate.

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 blockdev.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/blockdev.c b/blockdev.c
index 7f53cc8bb3..bf26c38195 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3884,35 +3884,30 @@ void qmp_blockdev_add(BlockdevOptions *options, Error **errp)
 {
     BlockDriverState *bs;
     QObject *obj;
-    Visitor *v = qobject_output_visitor_new(&obj);
     QDict *qdict;
     Error *local_err = NULL;

-    visit_type_BlockdevOptions(v, NULL, &options, &local_err);
+    obj = QAPI_TO_QOBJECT(BlockdevOptions, options, &local_err);
     if (local_err) {
         error_propagate(errp, local_err);
-        goto fail;
+        return;
     }

-    visit_complete(v, &obj);
     qdict = qobject_to_qdict(obj);

     qdict_flatten(qdict);

     if (!qdict_get_try_str(qdict, "node-name")) {
         error_setg(errp, "'node-name' must be specified for the root node");
-        goto fail;
+        return;
     }

     bs = bds_tree_init(qdict, errp);
     if (!bs) {
-        goto fail;
+        return;
     }

     QTAILQ_INSERT_TAIL(&monitor_bdrv_states, bs, monitor_list);
-
-fail:
-    visit_free(v);
 }

 void qmp_blockdev_del(const char *node_name, Error **errp)
-- 
2.13.3

  parent reply	other threads:[~2017-07-17 15:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 15:56 [Qemu-devel] [PATCH 0/5] Easier conversion from qapi to qobject Eric Blake
2017-07-17 15:56 ` [Qemu-devel] [PATCH 1/5] qapi: Add QAPI_TO_QOBJECT() convenience macro Eric Blake
2017-07-17 15:56 ` [Qemu-devel] [PATCH 2/5] nbd: Use simpler QAPI_TO_QOBJECT() Eric Blake
2017-07-17 15:56 ` [Qemu-devel] [PATCH 3/5] nfs: " Eric Blake
2017-07-17 15:56 ` [Qemu-devel] [PATCH 4/5] qapi: " Eric Blake
2017-07-17 15:56 ` Eric Blake [this message]
2017-07-17 16:02 ` [Qemu-devel] [PATCH 0/5] Easier conversion from qapi to qobject Eric Blake
2017-07-18 15:52   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170717155632.12754-6-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).