From: "Michael S. Tsirkin" <mst@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Ben Warren <ben@skyportsystems.com>
Subject: Re: [Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm
Date: Mon, 17 Jul 2017 16:21:05 +0300 [thread overview]
Message-ID: <20170717162054-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <374a73f0-b83a-1b1f-d28f-65610cffe364@redhat.com>
On Mon, Jul 17, 2017 at 09:28:15AM +0200, Laurent Vivier wrote:
> On 14/07/2017 16:37, Michael S. Tsirkin wrote:
> > On Fri, Jul 14, 2017 at 02:20:33AM -0400, Paolo Bonzini wrote:
> >>
> >>> NACK.
> >>>
> >>> It's not that simple. If you do it like this, you then suddenly get
> >>> these ugly '"kvm" accelerator not found' messages during "make check"
> >>> which we really should avoid.
> >>
> >> You're right, I thought these were shut up before with Laurent's patch.
> >> I think we should print a single message at the end, like
> >>
> >> qemu: -machine accel=kvm:xen: No accelerator found
> >>
> >> Paolo
> >
> > That's exactly Laurent's patch, isn't it?
> >
>
> Do you want I send an updated and a more formal patch?
>
> Thanks,
> Laurent
Yes pls.
next prev parent reply other threads:[~2017-07-17 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 16:47 [Qemu-devel] [PATCH] tests: switch pxe and vm gen id tests to use kvm Michael S. Tsirkin
2017-07-13 17:00 ` Paolo Bonzini
2017-07-14 5:59 ` Thomas Huth
2017-07-14 6:20 ` Paolo Bonzini
2017-07-14 14:37 ` Michael S. Tsirkin
2017-07-17 7:28 ` Laurent Vivier
2017-07-17 13:21 ` Michael S. Tsirkin [this message]
2017-07-14 14:45 ` Michael S. Tsirkin
2017-07-17 7:33 ` Thomas Huth
-- strict thread matches above, loose matches on Subject: below --
2017-07-13 16:43 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717162054-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ben@skyportsystems.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).