From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43324)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1dXEk5-0007wJ-RL
	for qemu-devel@nongnu.org; Mon, 17 Jul 2017 18:43:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1dXEk5-0003dJ-3q
	for qemu-devel@nongnu.org; Mon, 17 Jul 2017 18:43:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50126)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <famz@redhat.com>) id 1dXEk4-0003cR-UV
	for qemu-devel@nongnu.org; Mon, 17 Jul 2017 18:43:53 -0400
Date: Tue, 18 Jul 2017 06:43:48 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20170717224348.GB2585@lemon>
References: <20170717144848.11793-1-alex.bennee@linaro.org>
	<20170717144848.11793-5-alex.bennee@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20170717144848.11793-5-alex.bennee@linaro.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v1 04/23] docker: add debug tools to
 travis.docker
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= <f4bug@amsat.org>

On Mon, 07/17 15:48, Alex Benn=E9e wrote:
> When a test fails/hangs you don't want the hassle of getting the debug
> tools installed. Lets install them on our image by default so we can
> debug when we need to.

Makes sense for this image.

Reviewed-by: Fam Zheng <famz@redhat.com>

>=20
> Signed-off-by: Alex Benn=E9e <alex.bennee@linaro.org>
> ---
>  tests/docker/dockerfiles/travis.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dock=
erfiles/travis.docker
> index a315f66ad9..636fa590a5 100644
> --- a/tests/docker/dockerfiles/travis.docker
> +++ b/tests/docker/dockerfiles/travis.docker
> @@ -2,5 +2,5 @@ FROM quay.io/travisci/travis-ruby
>  RUN apt-get update
>  RUN apt-get -y build-dep qemu
>  RUN apt-get -y build-dep device-tree-compiler
> -RUN apt-get -y install python2.7 python-yaml dh-autoreconf
> +RUN apt-get -y install python2.7 python-yaml dh-autoreconf gdb strace =
lsof net-tools
>  ENV FEATURES pyyaml
> --=20
> 2.13.0
>=20