From: "Emilio G. Cota" <cota@braap.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: peter.maydell@linaro.org, rth@twiddle.net, qemu-devel@nongnu.org,
"Lluís Vilanova" <vilanova@ac.upc.edu>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/6] include/exec/exec-all: document common exit conditions
Date: Mon, 17 Jul 2017 20:02:44 -0400 [thread overview]
Message-ID: <20170718000244.GB30851@flamenco> (raw)
In-Reply-To: <20170711175937.23140-2-alex.bennee@linaro.org>
On Tue, Jul 11, 2017 at 18:59:32 +0100, Alex Bennée wrote:
> As a precursor to later patches attempt to come up with a more
> concrete wording for what each of the common exit cases would be.
(snip)
> + * In these cases as long as the PC is updated we can chain to the
> + * next TB either by exiting the loop or looking up the next TB via
> + * the loookup helper.
'o' x 3
> + *
> + * DISAS_UPDATE - CPU State was modified dynamically
> + *
> + * This covers any other CPU state which necessities us exiting the
> + * TCG code to the main run-loop.
s/necessities/necessitates/
Reviewed-by: Emilio G. Cota <cota@braap.org>
E.
next prev parent reply other threads:[~2017-07-18 0:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 17:59 [Qemu-devel] [PATCH v3 0/6] arm: fixes for eret, isb and DISAS_UPDATE handling Alex Bennée
2017-07-11 17:59 ` [Qemu-devel] [PATCH v3 1/6] include/exec/exec-all: document common exit conditions Alex Bennée
2017-07-11 18:17 ` Richard Henderson
2017-07-18 0:02 ` Emilio G. Cota [this message]
2017-07-11 17:59 ` [Qemu-devel] [PATCH v3 2/6] target/arm/translate: make DISAS_UPDATE match declared semantics Alex Bennée
2017-07-18 0:07 ` Emilio G. Cota
2017-07-11 17:59 ` [Qemu-devel] [PATCH v3 3/6] target/arm/translate.h: expand comment on DISAS_EXIT Alex Bennée
2017-07-18 0:08 ` Emilio G. Cota
2017-07-11 17:59 ` [Qemu-devel] [PATCH v3 4/6] target/arm/translate: ensure gen_goto_tb sets exit flags Alex Bennée
2017-07-11 18:16 ` Richard Henderson
2017-07-11 19:20 ` Alex Bennée
2017-07-11 21:08 ` Richard Henderson
2017-07-11 17:59 ` [Qemu-devel] [PATCH v3 5/6] target/arm: use gen_goto_tb for ISB handling Alex Bennée
2017-07-11 18:17 ` Richard Henderson
2017-07-18 0:11 ` Emilio G. Cota
2017-07-11 17:59 ` [Qemu-devel] [PATCH v3 6/6] target/arm: use DISAS_EXIT for eret handling Alex Bennée
2017-07-18 0:14 ` Emilio G. Cota
2017-07-11 18:18 ` [Qemu-devel] [PATCH v3 0/6] arm: fixes for eret, isb and DISAS_UPDATE handling Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718000244.GB30851@flamenco \
--to=cota@braap.org \
--cc=alex.bennee@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).