Re: [Qemu-devel] [Qemu-block] [PATCH 5/7] block: add throttle block filter driver

[Manos Pitsidianakis <el13635@mail.ntua.gr>]

[-- Attachment #1: Type: text/plain, Size: 2233 bytes --]

On Fri, Jul 14, 2017 at 12:45:19PM +0300, Manos Pitsidianakis wrote:
>+static BlockDriver bdrv_throttle = {
>+    .format_name                        =   "throttle",
>+    .protocol_name                      =   "throttle",
>+    .instance_size                      =   sizeof(ThrottleGroupMember),
>+
>+    .bdrv_file_open                     =   throttle_open,
>+    .bdrv_close                         =   throttle_close,
>+    .bdrv_co_flush                      =   throttle_co_flush,
>+
>+    .bdrv_child_perm                    =   bdrv_filter_default_perms,
>+
>+    .bdrv_getlength                     =   throttle_getlength,
>+
>+    .bdrv_co_preadv                     =   throttle_co_preadv,
>+    .bdrv_co_pwritev                    =   throttle_co_pwritev,
>+
>+    .bdrv_co_pwrite_zeroes              =   throttle_co_pwrite_zeroes,
>+    .bdrv_co_pdiscard                   =   throttle_co_pdiscard,
>+
>+    .bdrv_recurse_is_first_non_filter   =   bdrv_recurse_is_first_non_filter,

This is wrong! There should be a separate function to pass 
bdrv_recurse_is_first_non_filter to bs->file->bs.


>+    .bdrv_attach_aio_context            =   throttle_attach_aio_context,
>+    .bdrv_detach_aio_context            =   throttle_detach_aio_context,
>+
>+    .bdrv_reopen_prepare                =   throttle_reopen_prepare,
>+    .bdrv_reopen_commit                 =   throttle_reopen_commit,
>+    .bdrv_reopen_abort                  =   throttle_reopen_abort,
>+
>+    .is_filter                          =   true,
>+};
>+
>+static void bdrv_throttle_init(void)
>+{
>+    bdrv_register(&bdrv_throttle);
>+}
>+
>+block_init(bdrv_throttle_init);
>diff --git a/include/qemu/throttle-options.h b/include/qemu/throttle-options.h
>index 182b7896e1..508ee72625 100644
>--- a/include/qemu/throttle-options.h
>+++ b/include/qemu/throttle-options.h
>@@ -29,6 +29,7 @@
> #define QEMU_OPT_BPS_WRITE_MAX "bps-write-max"
> #define QEMU_OPT_BPS_WRITE_MAX_LENGTH "bps-write-max-length"
> #define QEMU_OPT_IOPS_SIZE "iops-size"
>+#define QEMU_OPT_THROTTLE_GROUP_NAME "throttling-group"
>
> #define THROTTLE_OPT_PREFIX "throttling."
> #define THROTTLE_OPTS \
>-- 
>2.11.0
>
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]