From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXP1v-0003Vh-08 for qemu-devel@nongnu.org; Tue, 18 Jul 2017 05:43:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXP1r-0002NJ-Oy for qemu-devel@nongnu.org; Tue, 18 Jul 2017 05:42:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41684) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dXP1r-0002MU-IC for qemu-devel@nongnu.org; Tue, 18 Jul 2017 05:42:55 -0400 Date: Tue, 18 Jul 2017 10:42:47 +0100 From: "Daniel P. Berrange" Message-ID: <20170718094247.GD11927@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170717063521.GA7393@lemon> <20170717231721.GE2585@lemon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] Status and RFC of patchew testings on QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Thomas Huth , Fam Zheng , QEMU Developers On Tue, Jul 18, 2017 at 10:37:30AM +0100, Peter Maydell wrote: > On 18 July 2017 at 10:11, Thomas Huth wrote: > > Could the test be rewritten to provide a proper timeout handling > > instead? Tests should clearly fail after a while instead of hanging > > forever... > > Or maybe we could add some magic that the troublesome tests are not > > executed if a certain environment variable is set, so we could skip them > > in these automated setups here? > > I think it's always going to be possible that some bug in > QEMU results in a test hanging -- so it must be down to > the test harness to deal with hanging tests. And then > once you have that functionality in the test harness it > doesn't matter quite so much whether an individual test > has its own timeout handling or not. If the tests are all inside a docker container, then dealing with a hanging test is no more difficult than waiting a suitable amount of time and then telling docker to destroy the container. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|