Re: [Qemu-devel] [PATCH 2/2] s390x/cpumodel: z14 cpu models

[Cornelia Huck <cohuck@redhat.com>]

On Mon, 17 Jul 2017 18:58:26 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> From: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
> 
> This patch introduces the CPU model for z14, along with all base and
> optional features.
> 
> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  target/s390x/cpu_models.c   |  1 +
>  target/s390x/gen-features.c | 38 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 39 insertions(+)
> 

> @@ -442,6 +450,23 @@ static uint16_t full_GEN13_GA1[] = {
>  
>  #define full_GEN13_GA2 EmptyFeat
>  
> +static uint16_t full_GEN14_GA1[] = {
> +    S390_FEAT_INSTRUCTION_EXEC_PROT,
> +    S390_FEAT_GUARDED_STORAGE,
> +    S390_FEAT_VECTOR_PACKED_DECIMAL,
> +    S390_FEAT_VECTOR_ENH,
> +    S390_FEAT_MULTIPLE_EPOCH,
> +    S390_FEAT_TEST_PENDING_EXT_INTERRUPTION,

Quick question: Is this a new instruction that does for external
interrupts what tpi does for I/O interrupts? If yes, is this an
intercept in kvm?

> +    S390_FEAT_INSERT_REFERENCE_BITS_MULT,
> +    S390_FEAT_GROUP_MSA_EXT_6,
> +    S390_FEAT_GROUP_MSA_EXT_7,
> +    S390_FEAT_GROUP_MSA_EXT_8,
> +    S390_FEAT_CMM_NT,
> +    S390_FEAT_HPMA2,
> +    S390_FEAT_SIE_KSS,
> +    S390_FEAT_ORDER_PRESERVING_COMPRESSION,
> +};
> +
>  /* Default features (in order of release)
>   * Automatically includes corresponding base features.
>   * Default features are all features this version of QEMU supports for this