From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXQzW-0008TM-0G for qemu-devel@nongnu.org; Tue, 18 Jul 2017 07:48:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXQzS-0008HI-VQ for qemu-devel@nongnu.org; Tue, 18 Jul 2017 07:48:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58210) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dXQzS-0008Gv-OX for qemu-devel@nongnu.org; Tue, 18 Jul 2017 07:48:34 -0400 Date: Tue, 18 Jul 2017 13:48:30 +0200 From: Igor Mammedov Message-ID: <20170718134830.07f8ee37@nial.brq.redhat.com> In-Reply-To: <20170712162058.10538-3-ehabkost@redhat.com> References: <20170712162058.10538-1-ehabkost@redhat.com> <20170712162058.10538-3-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] target/i386: Use host_vendor_fms() in max_x86_cpu_initfn() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Jiri Denemark , Paolo Bonzini , Richard Henderson On Wed, 12 Jul 2017 13:20:56 -0300 Eduardo Habkost wrote: > The existing code duplicated the logic in host_vendor_fms(), so > reuse the helper function instead. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > target/i386/cpu.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 30b704c..a667d5d 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -1588,13 +1588,8 @@ static void max_x86_cpu_initfn(Object *obj) > X86CPUDefinition host_cpudef = { }; > uint32_t eax = 0, ebx = 0, ecx = 0, edx = 0; > > - host_cpuid(0x0, 0, &eax, &ebx, &ecx, &edx); > - x86_cpu_vendor_words2str(host_cpudef.vendor, ebx, edx, ecx); > - > - host_cpuid(0x1, 0, &eax, &ebx, &ecx, &edx); > - host_cpudef.family = ((eax >> 8) & 0x0F) + ((eax >> 20) & 0xFF); > - host_cpudef.model = ((eax >> 4) & 0x0F) | ((eax & 0xF0000) >> 12); > - host_cpudef.stepping = eax & 0x0F; > + host_vendor_fms(host_cpudef.vendor, &host_cpudef.family, > + &host_cpudef.model, &host_cpudef.stepping); > > cpu_x86_fill_model_id(host_cpudef.model_id); >