qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL 4/8] target/alpha: Fix temp leak in gen_bcond
Date: Tue, 18 Jul 2017 18:45:18 -1000	[thread overview]
Message-ID: <20170719044522.21114-5-rth@twiddle.net> (raw)
In-Reply-To: <20170719044522.21114-1-rth@twiddle.net>

Tested-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target/alpha/translate.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/target/alpha/translate.c b/target/alpha/translate.c
index 140d6f3..d684a7b 100644
--- a/target/alpha/translate.c
+++ b/target/alpha/translate.c
@@ -565,16 +565,16 @@ static ExitStatus gen_bcond_internal(DisasContext *ctx, TCGCond cond,
 static ExitStatus gen_bcond(DisasContext *ctx, TCGCond cond, int ra,
                             int32_t disp, int mask)
 {
-    TCGv cmp_tmp;
-
     if (mask) {
-        cmp_tmp = tcg_temp_new();
-        tcg_gen_andi_i64(cmp_tmp, load_gpr(ctx, ra), 1);
-    } else {
-        cmp_tmp = load_gpr(ctx, ra);
-    }
+        TCGv tmp = tcg_temp_new();
+        ExitStatus ret;
 
-    return gen_bcond_internal(ctx, cond, cmp_tmp, disp);
+        tcg_gen_andi_i64(tmp, load_gpr(ctx, ra), 1);
+        ret = gen_bcond_internal(ctx, cond, tmp, disp);
+        tcg_temp_free(tmp);
+        return ret;
+    }
+    return gen_bcond_internal(ctx, cond, load_gpr(ctx, ra), disp);
 }
 
 /* Fold -0.0 for comparison with COND.  */
-- 
2.9.4

  parent reply	other threads:[~2017-07-19  4:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-19  4:45 [Qemu-devel] [PULL 0/8] target/alpha cleanups Richard Henderson
2017-07-19  4:45 ` [Qemu-devel] [PULL 1/8] target/alpha: Remove amask from tb->flags Richard Henderson
2017-07-19  4:45 ` [Qemu-devel] [PULL 2/8] target/alpha: Copy tb->flags into DisasContext Richard Henderson
2017-07-19  4:45 ` [Qemu-devel] [PULL 3/8] target/alpha: Merge several flag bytes into ENV->FLAGS Richard Henderson
2017-07-19  4:45 ` Richard Henderson [this message]
2017-07-19  4:45 ` [Qemu-devel] [PULL 5/8] target/alpha: Fix temp leak in gen_mtpr Richard Henderson
2017-07-19  4:45 ` [Qemu-devel] [PULL 6/8] target/alpha: Fix temp leak in gen_call_pal Richard Henderson
2017-07-19  4:45 ` [Qemu-devel] [PULL 7/8] target/alpha: Fix temp leak in gen_fbcond Richard Henderson
2017-07-19  4:45 ` [Qemu-devel] [PULL 8/8] target/alpha: Log temp leaks Richard Henderson
2017-07-19 16:57 ` [Qemu-devel] [PULL 0/8] target/alpha cleanups Peter Maydell
2017-07-19 21:52   ` Richard Henderson
2017-07-20  9:06     ` Peter Maydell
2017-07-20 22:44       ` Paolo Bonzini
2017-07-19 18:36 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170719044522.21114-5-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).