From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXjaE-0004ur-RI for qemu-devel@nongnu.org; Wed, 19 Jul 2017 03:39:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXjaA-0007al-4n for qemu-devel@nongnu.org; Wed, 19 Jul 2017 03:39:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33724) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dXja9-0007aO-UK for qemu-devel@nongnu.org; Wed, 19 Jul 2017 03:39:42 -0400 Date: Wed, 19 Jul 2017 09:39:42 +0200 From: Igor Mammedov Message-ID: <20170719093942.098dc2a0@Igors-MacBook-Pro.local> In-Reply-To: <20170718232650.GF8345@localhost.localdomain> References: <1500342577-12486-1-git-send-email-wang.yi59@zte.com.cn> <20170718165417.1b18bcbc@nial.brq.redhat.com> <20170718232650.GF8345@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Yi Wang , liu.yunh@zte.com.cn, qemu-devel@nongnu.org, dgilbert@redhat.com, pbonzini@redhat.com, Liu.Jianjun3@zte.com.cn, rth@twiddle.net On Tue, 18 Jul 2017 20:26:50 -0300 Eduardo Habkost wrote: > On Tue, Jul 18, 2017 at 04:54:17PM +0200, Igor Mammedov wrote: > > On Mon, 17 Jul 2017 21:49:37 -0400 > > Yi Wang wrote: > > > > > Add [vcpu] index support for hmp command "info lapic", which is > > > useful when debugging ipi and so on. Current behavior is not > > > changed when the parameter isn't specified. > > we shouldn't expose cpu_index to users anymore, > > > > I would suggest using to use real APIC ID here but we don't > > have monitor command that returns APIC IDs for present cpus. > > > > "info hotpluggable-cpus" gives you a list of available CPUs > > it also gives you qom_path to cpu so potentially you could > > read apic-id property of cpu. > > > > But we have only QMP variant of qom-get so monitor needs > > addition of qom-get command that will be a wrapper around > > QMP command. > > > > It could be solved in 2 ways: > > * use socket-id/core-id/thread-id to specify desired cpu > > /possible values in 'info hotpluggable-cpus'/ > > > > * use apic-id value to specify interrupt controller > > - apic-id could be retrieved with new qom-get > > (qom-get would also be useful to read other properties) > > - extend 'info registers' with apic id value > > for example instead of current: > > > > CPU#1 > > EAX=00000c06 EBX=00000000 ECX=000002ff EDX=00000000 > > .... > > > > it would look like: > > > > CPU#1 (socket-id: a, core-id: b, thread-id: c, apic-id: d) > > ... > > We already print "CPU #" on "info cpus", so is already a > perfectly good identifier for a human interface. I think HMP > should not require any identifier that isn't a simple number that > is shown very prominently on "info cpus". > > If we don't want to use cpu_index as an identifier anymore, we > can start printing arch ID instead of cpu_index on commands that > print "CPU #", and change mon_get_cpu() and monitor_set_cpu() > accordingly. Looks like a good plan, but it probably should touch all commands that use cpu_index, also I'd leave cpu_index in 'info cpus' where it is till we faze it out from CLI.