From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXrSk-0004sY-9l for qemu-devel@nongnu.org; Wed, 19 Jul 2017 12:04:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXrSg-0003Zq-Ax for qemu-devel@nongnu.org; Wed, 19 Jul 2017 12:04:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55544) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dXrSg-0003ZH-4I for qemu-devel@nongnu.org; Wed, 19 Jul 2017 12:04:30 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D18DCC04575D for ; Wed, 19 Jul 2017 16:04:28 +0000 (UTC) Date: Wed, 19 Jul 2017 17:04:19 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170719160418.GG3500@work-vm> References: <20170717134238.1966-1-quintela@redhat.com> <20170717134238.1966-4-quintela@redhat.com> <20170719154208.GD3500@work-vm> <20170719154345.GM30084@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170719154345.GM30084@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 03/17] qio: Create new qio_channel_{readv, writev}_all List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Juan Quintela , qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com * Daniel P. Berrange (berrange@redhat.com) wrote: > On Wed, Jul 19, 2017 at 04:42:09PM +0100, Dr. David Alan Gilbert wrote: > > * Juan Quintela (quintela@redhat.com) wrote: > > > The functions waits until it is able to write the full iov. > > > > When is it safe to call these - I see qio_channel_wait does it's > > own g_main_loop - so I guess they're intended to be called from their > > own process? > > > > What causes these to exit if the migration fails for some other > > (non-file) related reason? > > It'll exit if the other end closes the socket, or if the local QEMU > does a qio_channel_close() on it. I don't know if this patch series > uses either of those options tough. How do you safely cope with calling close on a socket that's currently being waited on/might be reading? In the cancel case we use shutdown() to force exits with out actually closing. Dave > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK