From: Amador Pahim <apahim@redhat.com>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, ehabkost@redhat.com, mreitz@redhat.com,
kwolf@redhat.com, armbru@redhat.com, crosa@redhat.com,
ldoktor@redhat.com, Amador Pahim <apahim@redhat.com>
Subject: [Qemu-devel] [PATCH v2 3/3] qemu.py: make 'args' public
Date: Wed, 19 Jul 2017 18:31:08 +0200 [thread overview]
Message-ID: <20170719163108.26943-4-apahim@redhat.com> (raw)
In-Reply-To: <20170719163108.26943-1-apahim@redhat.com>
Let's make args public so users can extend it without felling like
abusing the internal API.
Signed-off-by: Amador Pahim <apahim@redhat.com>
---
scripts/qemu.py | 13 +++++++------
tests/qemu-iotests/iotests.py | 18 +++++++++---------
2 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 2707ae7f75..2c2043f89a 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -34,7 +34,7 @@ class QEMUMachine(object):
self._qemu_log_path = os.path.join(test_dir, name + ".log")
self._popen = None
self._binary = binary
- self._args = list(args) # Force copy args in case we modify them
+ self.args = list(args) # Force copy args in case we modify them
self._wrapper = wrapper
self._events = []
self._iolog = None
@@ -44,8 +44,8 @@ class QEMUMachine(object):
# This can be used to add an unused monitor instance.
def add_monitor_telnet(self, ip, port):
args = 'tcp:%s:%d,server,nowait,telnet' % (ip, port)
- self._args.append('-monitor')
- self._args.append(args)
+ self.args.append('-monitor')
+ self.args.append(args)
def add_fd(self, fd, fdset, opaque, opts=''):
'''Pass a file descriptor to the VM'''
@@ -55,8 +55,8 @@ class QEMUMachine(object):
if opts:
options.append(opts)
- self._args.append('-add-fd')
- self._args.append(','.join(options))
+ self.args.append('-add-fd')
+ self.args.append(','.join(options))
return self
def send_fd_scm(self, fd_file_path):
@@ -168,7 +168,8 @@ class QEMUMachine(object):
exitcode = self._popen.wait()
if exitcode < 0:
- sys.stderr.write('qemu received signal %i: %s\n' % (-exitcode, ' '.join(self._args)))
+ sys.stderr.write('qemu received signal %i: %s\n' %
+ (-exitcode, ' '.join(self.args)))
self._load_io_log()
self._post_shutdown()
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index abcf3c10e2..6925d8841e 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -150,13 +150,13 @@ class VM(qtest.QEMUQtestMachine):
self._num_drives = 0
def add_device(self, opts):
- self._args.append('-device')
- self._args.append(opts)
+ self.args.append('-device')
+ self.args.append(opts)
return self
def add_drive_raw(self, opts):
- self._args.append('-drive')
- self._args.append(opts)
+ self.args.append('-drive')
+ self.args.append(opts)
return self
def add_drive(self, path, opts='', interface='virtio', format=imgfmt):
@@ -172,17 +172,17 @@ class VM(qtest.QEMUQtestMachine):
if opts:
options.append(opts)
- self._args.append('-drive')
- self._args.append(','.join(options))
+ self.args.append('-drive')
+ self.args.append(','.join(options))
self._num_drives += 1
return self
def add_blockdev(self, opts):
- self._args.append('-blockdev')
+ self.args.append('-blockdev')
if isinstance(opts, str):
- self._args.append(opts)
+ self.args.append(opts)
else:
- self._args.append(','.join(opts))
+ self.args.append(','.join(opts))
return self
def pause_drive(self, drive, event=None):
--
2.13.3
next prev parent reply other threads:[~2017-07-19 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 16:31 [Qemu-devel] [PATCH v2 0/3] scripts/qemu.py small fixes Amador Pahim
2017-07-19 16:31 ` [Qemu-devel] [PATCH v2 1/3] qemu.py: fix is_running() Amador Pahim
2017-07-19 18:34 ` Eduardo Habkost
2017-07-19 19:02 ` Eduardo Habkost
2017-07-20 2:40 ` Fam Zheng
2017-07-19 16:31 ` [Qemu-devel] [PATCH v2 2/3] qemu.py: include debug information on launch error Amador Pahim
2017-07-20 2:57 ` Fam Zheng
2017-07-19 16:31 ` Amador Pahim [this message]
2017-07-20 2:38 ` [Qemu-devel] [PATCH v2 3/3] qemu.py: make 'args' public Fam Zheng
2017-07-20 2:57 ` Fam Zheng
2017-07-19 17:01 ` [Qemu-devel] [PATCH v2 0/3] scripts/qemu.py small fixes no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719163108.26943-4-apahim@redhat.com \
--to=apahim@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=ldoktor@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).