From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dY1Mk-0001sb-Vy for qemu-devel@nongnu.org; Wed, 19 Jul 2017 22:39:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dY1Mh-0007Ox-S8 for qemu-devel@nongnu.org; Wed, 19 Jul 2017 22:39:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51320) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dY1Mh-0007OE-IP for qemu-devel@nongnu.org; Wed, 19 Jul 2017 22:38:59 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6F6BF80F94 for ; Thu, 20 Jul 2017 02:38:58 +0000 (UTC) Date: Thu, 20 Jul 2017 10:38:54 +0800 From: Fam Zheng Message-ID: <20170720023854.GB11032@lemon> References: <20170719163108.26943-1-apahim@redhat.com> <20170719163108.26943-4-apahim@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170719163108.26943-4-apahim@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 3/3] qemu.py: make 'args' public List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amador Pahim Cc: qemu-devel@nongnu.org, kwolf@redhat.com, ldoktor@redhat.com, ehabkost@redhat.com, armbru@redhat.com, mreitz@redhat.com, crosa@redhat.com On Wed, 07/19 18:31, Amador Pahim wrote: > Let's make args public so users can extend it without felling like > abusing the internal API. s/felling/feeling/ ? Fam > > Signed-off-by: Amador Pahim > --- > scripts/qemu.py | 13 +++++++------ > tests/qemu-iotests/iotests.py | 18 +++++++++--------- > 2 files changed, 16 insertions(+), 15 deletions(-) > > diff --git a/scripts/qemu.py b/scripts/qemu.py > index 2707ae7f75..2c2043f89a 100644 > --- a/scripts/qemu.py > +++ b/scripts/qemu.py > @@ -34,7 +34,7 @@ class QEMUMachine(object): > self._qemu_log_path = os.path.join(test_dir, name + ".log") > self._popen = None > self._binary = binary > - self._args = list(args) # Force copy args in case we modify them > + self.args = list(args) # Force copy args in case we modify them > self._wrapper = wrapper > self._events = [] > self._iolog = None > @@ -44,8 +44,8 @@ class QEMUMachine(object): > # This can be used to add an unused monitor instance. > def add_monitor_telnet(self, ip, port): > args = 'tcp:%s:%d,server,nowait,telnet' % (ip, port) > - self._args.append('-monitor') > - self._args.append(args) > + self.args.append('-monitor') > + self.args.append(args) > > def add_fd(self, fd, fdset, opaque, opts=''): > '''Pass a file descriptor to the VM''' > @@ -55,8 +55,8 @@ class QEMUMachine(object): > if opts: > options.append(opts) > > - self._args.append('-add-fd') > - self._args.append(','.join(options)) > + self.args.append('-add-fd') > + self.args.append(','.join(options)) > return self > > def send_fd_scm(self, fd_file_path): > @@ -168,7 +168,8 @@ class QEMUMachine(object): > > exitcode = self._popen.wait() > if exitcode < 0: > - sys.stderr.write('qemu received signal %i: %s\n' % (-exitcode, ' '.join(self._args))) > + sys.stderr.write('qemu received signal %i: %s\n' % > + (-exitcode, ' '.join(self.args))) > self._load_io_log() > self._post_shutdown() > > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py > index abcf3c10e2..6925d8841e 100644 > --- a/tests/qemu-iotests/iotests.py > +++ b/tests/qemu-iotests/iotests.py > @@ -150,13 +150,13 @@ class VM(qtest.QEMUQtestMachine): > self._num_drives = 0 > > def add_device(self, opts): > - self._args.append('-device') > - self._args.append(opts) > + self.args.append('-device') > + self.args.append(opts) > return self > > def add_drive_raw(self, opts): > - self._args.append('-drive') > - self._args.append(opts) > + self.args.append('-drive') > + self.args.append(opts) > return self > > def add_drive(self, path, opts='', interface='virtio', format=imgfmt): > @@ -172,17 +172,17 @@ class VM(qtest.QEMUQtestMachine): > if opts: > options.append(opts) > > - self._args.append('-drive') > - self._args.append(','.join(options)) > + self.args.append('-drive') > + self.args.append(','.join(options)) > self._num_drives += 1 > return self > > def add_blockdev(self, opts): > - self._args.append('-blockdev') > + self.args.append('-blockdev') > if isinstance(opts, str): > - self._args.append(opts) > + self.args.append(opts) > else: > - self._args.append(','.join(opts)) > + self.args.append(','.join(opts)) > return self > > def pause_drive(self, drive, event=None): > -- > 2.13.3 > >