From: Fam Zheng <famz@redhat.com>
To: Amador Pahim <apahim@redhat.com>
Cc: kwolf@redhat.com, ldoktor@redhat.com, ehabkost@redhat.com,
armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com,
crosa@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/3] qemu.py: make 'args' public
Date: Thu, 20 Jul 2017 10:57:33 +0800 [thread overview]
Message-ID: <20170720025733.GE11032@lemon> (raw)
In-Reply-To: <20170720023854.GB11032@lemon>
On Thu, 07/20 10:38, Fam Zheng wrote:
> On Wed, 07/19 18:31, Amador Pahim wrote:
> > Let's make args public so users can extend it without felling like
> > abusing the internal API.
>
> s/felling/feeling/ ?
Apart from that:
Reviewed-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2017-07-20 2:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 16:31 [Qemu-devel] [PATCH v2 0/3] scripts/qemu.py small fixes Amador Pahim
2017-07-19 16:31 ` [Qemu-devel] [PATCH v2 1/3] qemu.py: fix is_running() Amador Pahim
2017-07-19 18:34 ` Eduardo Habkost
2017-07-19 19:02 ` Eduardo Habkost
2017-07-20 2:40 ` Fam Zheng
2017-07-19 16:31 ` [Qemu-devel] [PATCH v2 2/3] qemu.py: include debug information on launch error Amador Pahim
2017-07-20 2:57 ` Fam Zheng
2017-07-19 16:31 ` [Qemu-devel] [PATCH v2 3/3] qemu.py: make 'args' public Amador Pahim
2017-07-20 2:38 ` Fam Zheng
2017-07-20 2:57 ` Fam Zheng [this message]
2017-07-19 17:01 ` [Qemu-devel] [PATCH v2 0/3] scripts/qemu.py small fixes no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720025733.GE11032@lemon \
--to=famz@redhat.com \
--cc=apahim@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=ldoktor@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).