From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dY927-0000ZH-TR for qemu-devel@nongnu.org; Thu, 20 Jul 2017 06:50:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dY924-0007tZ-P9 for qemu-devel@nongnu.org; Thu, 20 Jul 2017 06:50:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51562) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dY924-0007rn-G4 for qemu-devel@nongnu.org; Thu, 20 Jul 2017 06:50:12 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 836157F3F8 for ; Thu, 20 Jul 2017 10:50:09 +0000 (UTC) Date: Thu, 20 Jul 2017 11:50:04 +0100 From: "Daniel P. Berrange" Message-ID: <20170720105004.GA26866@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170407143847.GM2138@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170407143847.GM2138@work-vm> Subject: Re: [Qemu-devel] Hacks for building on gcc 7 / Fedora 26 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org On Fri, Apr 07, 2017 at 03:38:47PM +0100, Dr. David Alan Gilbert wrote: > Hi, > Fedora 26 has gcc 7.0.1 which has the normal compliment > of new fussy warnings; so far I've posted : > > tests/check-qdict: Fix missing brackets > slirp/smb: Replace constant strings by glib string > > that fix one actual mistake and work around something it's being > fussy over. > > But I've also got a pile of hacks, attached below that I'm > not too sure what I'll do with them yet, but they're attached > for anyone else trying to build. Note they're smoke-only-tested. > > I also have gcc bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80346 > filed for what I reckon is a couple of overly pessimistic warnings. > diff --git a/include/qemu/iov.h b/include/qemu/iov.h > index bd9fd55b0a..ebb0221140 100644 > --- a/include/qemu/iov.h > +++ b/include/qemu/iov.h > @@ -46,7 +46,7 @@ static inline size_t > iov_from_buf(const struct iovec *iov, unsigned int iov_cnt, > size_t offset, const void *buf, size_t bytes) > { > - if (__builtin_constant_p(bytes) && iov_cnt && > + if (__builtin_constant_p(bytes) && iov_cnt && bytes <= INT_MAX && > offset <= iov[0].iov_len && bytes <= iov[0].iov_len - offset) { > memcpy(iov[0].iov_base + offset, buf, bytes); > return bytes; > @@ -59,7 +59,7 @@ static inline size_t > iov_to_buf(const struct iovec *iov, const unsigned int iov_cnt, > size_t offset, void *buf, size_t bytes) > { > - if (__builtin_constant_p(bytes) && iov_cnt && > + if (__builtin_constant_p(bytes) && iov_cnt && bytes <= INT_MAX && > offset <= iov[0].iov_len && bytes <= iov[0].iov_len - offset) { > memcpy(buf, iov[0].iov_base + offset, bytes); > return bytes; > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 88dbf97853..c55de4f65b 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -98,7 +98,7 @@ static void test_acpi_rsdt_table(test_data *data) > AcpiRsdtDescriptorRev1 *rsdt_table = &data->rsdt_table; > uint32_t addr = data->rsdp_table.rsdt_physical_address; > uint32_t *tables; > - int tables_nr; > + unsigned int tables_nr; > uint8_t checksum; > > /* read the header */ Unless I've missed a patch somwhere, I think the problems that these two chunks are fixing are still needed for current git master, to stop warnings in the unit tests. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|