From: Stefan Hajnoczi <stefanha@redhat.com>
To: Ishani Chugh <chugh.ishani@research.iiit.ac.in>
Cc: qemu-devel@nongnu.org, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6] Add manpage for QEMU Backup Tool
Date: Thu, 20 Jul 2017 13:46:18 +0100 [thread overview]
Message-ID: <20170720124618.GD32383@stefanha-x1.localdomain> (raw)
In-Reply-To: <1500318936-14106-1-git-send-email-chugh.ishani@research.iiit.ac.in>
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
On Tue, Jul 18, 2017 at 12:45:36AM +0530, Ishani Chugh wrote:
This looks good. I think it makes sense to include this patch with the
patch series that adds the qemu-backup command. That way the command
and its man page will be merged together.
> +@item qemu-backup guest add --guest guestname --qmp socketpath [--tcp]
For consistency I suggest following QEMU chardev syntax for the socket
path. This also allows you to drop --tcp.
UNIX domain sockets look like this:
unix:/path/to/socket
TCP addresses look like this:
tcp:127.0.0.1:1234
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-07-20 12:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 19:15 [Qemu-devel] [PATCH v6] Add manpage for QEMU Backup Tool Ishani Chugh
2017-07-20 12:46 ` Stefan Hajnoczi [this message]
2017-07-20 20:58 ` Ishani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720124618.GD32383@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=chugh.ishani@research.iiit.ac.in \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).