From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: famz@redhat.com, qemu-devel@nongnu.org,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [RFC PATCH for 2.10 3/3] docker: ignore submodules when checking diff
Date: Thu, 20 Jul 2017 14:47:16 +0100 [thread overview]
Message-ID: <20170720134716.13049-4-alex.bennee@linaro.org> (raw)
In-Reply-To: <20170720134716.13049-1-alex.bennee@linaro.org>
The QEMU tree often has dirty submodules in it but this will confuse
things as git stash is not going to save their state directly. They
are likely just dirty from build files anyway. Ignore them in the
diff-index command.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/docker/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index ff580edfad..2a560a5327 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -20,7 +20,7 @@ IMAGES ?= %
# Make archive from git repo $1 to tar.gz $2
make-archive-maybe = $(if $(wildcard $1/*), \
$(call quiet-command, \
- (cd $1; if git diff-index --quiet HEAD -- 2>/dev/null; then \
+ (cd $1; if git diff-index --quiet --ignore-submodules HEAD -- 2>/dev/null; then \
git archive -1 HEAD --format=tar.gz; \
else \
git archive -1 $$(git stash create) --format=tar.gz; \
--
2.13.0
next prev parent reply other threads:[~2017-07-20 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 13:47 [Qemu-devel] [RFC PATCH for 2.10 0/3] some docker fixes Alex Bennée
2017-07-20 13:47 ` [Qemu-devel] [RFC PATCH for 2.10 1/3] docker: ensure NOUSER for travis images Alex Bennée
2017-07-25 4:57 ` Philippe Mathieu-Daudé
2017-07-25 12:16 ` Alex Bennée
2017-07-20 13:47 ` [Qemu-devel] [RFC PATCH for 2.10 2/3] docker: fix dirty/stash detection on some systems Alex Bennée
2017-07-20 13:58 ` Eric Blake
2017-07-24 16:27 ` Philippe Mathieu-Daudé
2017-07-20 13:47 ` Alex Bennée [this message]
2017-07-20 13:57 ` [Qemu-devel] [RFC PATCH for 2.10 3/3] docker: ignore submodules when checking diff Eric Blake
2017-07-24 14:22 ` [Qemu-devel] [RFC PATCH for 2.10 0/3] some docker fixes Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720134716.13049-4-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).