* [Qemu-devel] [PATCH 0/1] fixup for the z14 cpu model @ 2017-07-20 11:27 Christian Borntraeger 2017-07-20 11:27 ` [Qemu-devel] [PATCH 1/1] s390/cpumodel: remove KSS from the default model of z14 Christian Borntraeger 0 siblings, 1 reply; 7+ messages in thread From: Christian Borntraeger @ 2017-07-20 11:27 UTC (permalink / raw) To: Cornelia Huck Cc: qemu-devel, Alexander Graf, Richard Henderson, Thomas Huth, David Hildenbrand, Christian Borntraeger More testing revealed a small issue with the z14 cpu model. Christian Borntraeger (1): s390/cpumodel: remove KSS from the default model of z14 target/s390x/cpu_models.c | 1 + target/s390x/gen-features.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [PATCH 1/1] s390/cpumodel: remove KSS from the default model of z14 2017-07-20 11:27 [Qemu-devel] [PATCH 0/1] fixup for the z14 cpu model Christian Borntraeger @ 2017-07-20 11:27 ` Christian Borntraeger 2017-07-20 12:27 ` David Hildenbrand ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Christian Borntraeger @ 2017-07-20 11:27 UTC (permalink / raw) To: Cornelia Huck Cc: qemu-devel, Alexander Graf, Richard Henderson, Thomas Huth, David Hildenbrand, Christian Borntraeger The SIE_KSS feature will allow a guest to use KSS for a nested guest. To create a nested guest the SIE_F2 facility is still necessary. Since SIE_F2 is not part of the default model it does not make a lot of sense to provide the SIE_KSS feature in the default model. Let's also create a dependency check. Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> Reviewed-by: Jason J. Herne <jjherne@linux.vnet.ibm.com> Reviewed-by: Janosch Frank <frankja@linux.vnet.ibm.com> --- target/s390x/cpu_models.c | 1 + target/s390x/gen-features.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index f4e5bb6..d91b7b8 100644 --- a/target/s390x/cpu_models.c +++ b/target/s390x/cpu_models.c @@ -723,6 +723,7 @@ static void check_consistency(const S390CPUModel *model) { S390_FEAT_KLMD_SHAKE_256, S390_FEAT_MSA }, { S390_FEAT_PRNO_TRNG_QRTCR, S390_FEAT_MSA_EXT_5 }, { S390_FEAT_PRNO_TRNG, S390_FEAT_MSA_EXT_5 }, + { S390_FEAT_SIE_KSS, S390_FEAT_SIE_F2 }, }; int i; diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index cf69157..c8dc104 100644 --- a/target/s390x/gen-features.c +++ b/target/s390x/gen-features.c @@ -535,7 +535,6 @@ static uint16_t default_GEN14_GA1[] = { S390_FEAT_GROUP_MSA_EXT_6, S390_FEAT_GROUP_MSA_EXT_7, S390_FEAT_GROUP_MSA_EXT_8, - S390_FEAT_SIE_KSS, }; /****** END FEATURE DEFS ******/ -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] s390/cpumodel: remove KSS from the default model of z14 2017-07-20 11:27 ` [Qemu-devel] [PATCH 1/1] s390/cpumodel: remove KSS from the default model of z14 Christian Borntraeger @ 2017-07-20 12:27 ` David Hildenbrand 2017-07-20 13:05 ` Cornelia Huck 2017-07-20 13:25 ` Cornelia Huck 2 siblings, 0 replies; 7+ messages in thread From: David Hildenbrand @ 2017-07-20 12:27 UTC (permalink / raw) To: Christian Borntraeger, Cornelia Huck Cc: qemu-devel, Alexander Graf, Richard Henderson, Thomas Huth On 20.07.2017 13:27, Christian Borntraeger wrote: > The SIE_KSS feature will allow a guest to use KSS for a nested guest. > To create a nested guest the SIE_F2 facility is still necessary. > Since SIE_F2 is not part of the default model it does not make > a lot of sense to provide the SIE_KSS feature in the default model. > Let's also create a dependency check. Makes sense. Acked-by: David Hildenbrand <david@redhat.com> > > Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> > Reviewed-by: Jason J. Herne <jjherne@linux.vnet.ibm.com> > Reviewed-by: Janosch Frank <frankja@linux.vnet.ibm.com> > --- > target/s390x/cpu_models.c | 1 + > target/s390x/gen-features.c | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > index f4e5bb6..d91b7b8 100644 > --- a/target/s390x/cpu_models.c > +++ b/target/s390x/cpu_models.c > @@ -723,6 +723,7 @@ static void check_consistency(const S390CPUModel *model) > { S390_FEAT_KLMD_SHAKE_256, S390_FEAT_MSA }, > { S390_FEAT_PRNO_TRNG_QRTCR, S390_FEAT_MSA_EXT_5 }, > { S390_FEAT_PRNO_TRNG, S390_FEAT_MSA_EXT_5 }, > + { S390_FEAT_SIE_KSS, S390_FEAT_SIE_F2 }, > }; > int i; > > diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c > index cf69157..c8dc104 100644 > --- a/target/s390x/gen-features.c > +++ b/target/s390x/gen-features.c > @@ -535,7 +535,6 @@ static uint16_t default_GEN14_GA1[] = { > S390_FEAT_GROUP_MSA_EXT_6, > S390_FEAT_GROUP_MSA_EXT_7, > S390_FEAT_GROUP_MSA_EXT_8, > - S390_FEAT_SIE_KSS, > }; > > /****** END FEATURE DEFS ******/ > -- Thanks, David ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] s390/cpumodel: remove KSS from the default model of z14 2017-07-20 11:27 ` [Qemu-devel] [PATCH 1/1] s390/cpumodel: remove KSS from the default model of z14 Christian Borntraeger 2017-07-20 12:27 ` David Hildenbrand @ 2017-07-20 13:05 ` Cornelia Huck 2017-07-20 13:10 ` Christian Borntraeger 2017-07-20 13:25 ` Cornelia Huck 2 siblings, 1 reply; 7+ messages in thread From: Cornelia Huck @ 2017-07-20 13:05 UTC (permalink / raw) To: Christian Borntraeger Cc: qemu-devel, Alexander Graf, Richard Henderson, Thomas Huth, David Hildenbrand On Thu, 20 Jul 2017 13:27:31 +0200 Christian Borntraeger <borntraeger@de.ibm.com> wrote: > The SIE_KSS feature will allow a guest to use KSS for a nested guest. > To create a nested guest the SIE_F2 facility is still necessary. > Since SIE_F2 is not part of the default model it does not make > a lot of sense to provide the SIE_KSS feature in the default model. > Let's also create a dependency check. > > Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> > Reviewed-by: Jason J. Herne <jjherne@linux.vnet.ibm.com> > Reviewed-by: Janosch Frank <frankja@linux.vnet.ibm.com> > --- > target/s390x/cpu_models.c | 1 + > target/s390x/gen-features.c | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) I can either queue this; or, if you want to push this out as a fixup, feel free to add Acked-by: Cornelia Huck <cohuck@redhat.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] s390/cpumodel: remove KSS from the default model of z14 2017-07-20 13:05 ` Cornelia Huck @ 2017-07-20 13:10 ` Christian Borntraeger 2017-07-20 13:12 ` Cornelia Huck 0 siblings, 1 reply; 7+ messages in thread From: Christian Borntraeger @ 2017-07-20 13:10 UTC (permalink / raw) To: Cornelia Huck Cc: qemu-devel, Alexander Graf, Richard Henderson, Thomas Huth, David Hildenbrand On 07/20/2017 03:05 PM, Cornelia Huck wrote: > On Thu, 20 Jul 2017 13:27:31 +0200 > Christian Borntraeger <borntraeger@de.ibm.com> wrote: > >> The SIE_KSS feature will allow a guest to use KSS for a nested guest. >> To create a nested guest the SIE_F2 facility is still necessary. >> Since SIE_F2 is not part of the default model it does not make >> a lot of sense to provide the SIE_KSS feature in the default model. >> Let's also create a dependency check. >> >> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> >> Reviewed-by: Jason J. Herne <jjherne@linux.vnet.ibm.com> >> Reviewed-by: Janosch Frank <frankja@linux.vnet.ibm.com> >> --- >> target/s390x/cpu_models.c | 1 + >> target/s390x/gen-features.c | 1 - >> 2 files changed, 1 insertion(+), 1 deletion(-) > > I can either queue this; or, if you want to push this out as a fixup, > feel free to add I want this in 2.10, but it can wait some days of course. I am on vacation starting end of next week, so maybe its better if you do the next round (and also take care of Davids and Thomas patches if those are appropriate for 2.10) Thanks a lot > Acked-by: Cornelia Huck <cohuck@redhat.com> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] s390/cpumodel: remove KSS from the default model of z14 2017-07-20 13:10 ` Christian Borntraeger @ 2017-07-20 13:12 ` Cornelia Huck 0 siblings, 0 replies; 7+ messages in thread From: Cornelia Huck @ 2017-07-20 13:12 UTC (permalink / raw) To: Christian Borntraeger Cc: qemu-devel, Alexander Graf, Richard Henderson, Thomas Huth, David Hildenbrand On Thu, 20 Jul 2017 15:10:35 +0200 Christian Borntraeger <borntraeger@de.ibm.com> wrote: > On 07/20/2017 03:05 PM, Cornelia Huck wrote: > > On Thu, 20 Jul 2017 13:27:31 +0200 > > Christian Borntraeger <borntraeger@de.ibm.com> wrote: > > > >> The SIE_KSS feature will allow a guest to use KSS for a nested guest. > >> To create a nested guest the SIE_F2 facility is still necessary. > >> Since SIE_F2 is not part of the default model it does not make > >> a lot of sense to provide the SIE_KSS feature in the default model. > >> Let's also create a dependency check. > >> > >> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> > >> Reviewed-by: Jason J. Herne <jjherne@linux.vnet.ibm.com> > >> Reviewed-by: Janosch Frank <frankja@linux.vnet.ibm.com> > >> --- > >> target/s390x/cpu_models.c | 1 + > >> target/s390x/gen-features.c | 1 - > >> 2 files changed, 1 insertion(+), 1 deletion(-) > > > > I can either queue this; or, if you want to push this out as a fixup, > > feel free to add > > I want this in 2.10, but it can wait some days of course. I am on vacation > starting end of next week, so maybe its better if you do the next round > (and also take care of Davids and Thomas patches if those are appropriate > for 2.10) > > Thanks a lot OK, I'll deal with this next week. I've got the vfio-ccw patches as well, anyway. > > Acked-by: Cornelia Huck <cohuck@redhat.com> > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] s390/cpumodel: remove KSS from the default model of z14 2017-07-20 11:27 ` [Qemu-devel] [PATCH 1/1] s390/cpumodel: remove KSS from the default model of z14 Christian Borntraeger 2017-07-20 12:27 ` David Hildenbrand 2017-07-20 13:05 ` Cornelia Huck @ 2017-07-20 13:25 ` Cornelia Huck 2 siblings, 0 replies; 7+ messages in thread From: Cornelia Huck @ 2017-07-20 13:25 UTC (permalink / raw) To: Christian Borntraeger Cc: qemu-devel, Alexander Graf, Richard Henderson, Thomas Huth, David Hildenbrand On Thu, 20 Jul 2017 13:27:31 +0200 Christian Borntraeger <borntraeger@de.ibm.com> wrote: > The SIE_KSS feature will allow a guest to use KSS for a nested guest. > To create a nested guest the SIE_F2 facility is still necessary. > Since SIE_F2 is not part of the default model it does not make > a lot of sense to provide the SIE_KSS feature in the default model. > Let's also create a dependency check. > > Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> > Reviewed-by: Jason J. Herne <jjherne@linux.vnet.ibm.com> > Reviewed-by: Janosch Frank <frankja@linux.vnet.ibm.com> > --- > target/s390x/cpu_models.c | 1 + > target/s390x/gen-features.c | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) Thanks, queued to s390-next. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-07-20 13:25 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-07-20 11:27 [Qemu-devel] [PATCH 0/1] fixup for the z14 cpu model Christian Borntraeger 2017-07-20 11:27 ` [Qemu-devel] [PATCH 1/1] s390/cpumodel: remove KSS from the default model of z14 Christian Borntraeger 2017-07-20 12:27 ` David Hildenbrand 2017-07-20 13:05 ` Cornelia Huck 2017-07-20 13:10 ` Christian Borntraeger 2017-07-20 13:12 ` Cornelia Huck 2017-07-20 13:25 ` Cornelia Huck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).