From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYG3I-0007kH-2m for qemu-devel@nongnu.org; Thu, 20 Jul 2017 14:19:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYG3B-0006nt-Tc for qemu-devel@nongnu.org; Thu, 20 Jul 2017 14:19:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11236) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dYG3B-0006nm-Ng for qemu-devel@nongnu.org; Thu, 20 Jul 2017 14:19:49 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B953885547 for ; Thu, 20 Jul 2017 18:19:48 +0000 (UTC) Date: Thu, 20 Jul 2017 15:19:40 -0300 From: Eduardo Habkost Message-ID: <20170720181940.GT2757@localhost.localdomain> References: <20170720162815.19802-1-ldoktor@redhat.com> <20170720162815.19802-4-ldoktor@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170720162815.19802-4-ldoktor@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 03/11] qemu.py: Use iteritems rather than keys() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?B?THVrw6HFoQ==?= Doktor Cc: apahim@redhat.com, qemu-devel@nongnu.org, famz@redhat.com, armbru@redhat.com, mreitz@redhat.com On Thu, Jul 20, 2017 at 06:28:07PM +0200, Luk=C3=A1=C5=A1 Doktor wrote: > Let's avoid creating an in-memory list of keys and query for each value > and use `iteritems` which is an iterator of key-value pairs. >=20 > Signed-off-by: Luk=C3=A1=C5=A1 Doktor Reviewed-by: Eduardo Habkost --=20 Eduardo