From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYG47-0008FM-1P for qemu-devel@nongnu.org; Thu, 20 Jul 2017 14:20:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYG42-0007DX-0B for qemu-devel@nongnu.org; Thu, 20 Jul 2017 14:20:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47646) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dYG41-0007DL-I1 for qemu-devel@nongnu.org; Thu, 20 Jul 2017 14:20:41 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 93F1CC058EB0 for ; Thu, 20 Jul 2017 18:20:40 +0000 (UTC) Date: Thu, 20 Jul 2017 15:20:32 -0300 From: Eduardo Habkost Message-ID: <20170720182032.GU2757@localhost.localdomain> References: <20170720162815.19802-1-ldoktor@redhat.com> <20170720162815.19802-5-ldoktor@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170720162815.19802-5-ldoktor@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 04/11] qemu.py: Simplify QMP key-conversion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?B?THVrw6HFoQ==?= Doktor Cc: apahim@redhat.com, qemu-devel@nongnu.org, famz@redhat.com, armbru@redhat.com, mreitz@redhat.com On Thu, Jul 20, 2017 at 06:28:08PM +0200, Luk=C3=A1=C5=A1 Doktor wrote: > The QMP key conversion consist of '_'s to be replaced with '-'s, which > can easily be done by a single `str.replace` method which is faster and > does not require `string` module import. >=20 > Signed-off-by: Luk=C3=A1=C5=A1 Doktor Reviewed-by: Eduardo Habkost --=20 Eduardo