qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Andrew Baumann <Andrew.Baumann@microsoft.com>,
	jsnow@redhat.com, Max Reitz <mreitz@redhat.com>,
	eblake@redhat.com
Subject: [Qemu-devel] [PATCH 0/2] block: Do OFD lock check at runtime
Date: Fri, 21 Jul 2017 18:20:57 +0800	[thread overview]
Message-ID: <20170721102059.14663-1-famz@redhat.com> (raw)

This fixes the image opening failure reported by Andrew Baumann:

> I'm running a recent Linux build of qemu on Windows Subsystem for Linux (WSL)
> which doesn't appear to implement file locking:
>
> $ qemu-system-aarch64 ... -drive file=test.vhdx,if=none,id=hd0 -device virtio-blk-pci,drive=hd0
> qemu-system-aarch64: -drive file=test.vhdx,if=none,id=hd0: Failed to unlock byte 100
> qemu-system-aarch64: -drive file=test.vhdx,if=none,id=hd0: Failed to unlock byte 100
> qemu-system-aarch64: -drive file=test.vhdx,if=none,id=hd0: Failed to lock byte 100

It appears to be that the binary is built for Linux targets, but the WSL
runtime doesn't recognize the ops (-EINVAL).

Convert to runtime check to cope with that.

Fam Zheng (2):
  osdep: Add runtime OFD lock detection
  file-posix: Do runtime check for ofd lock API

 block/file-posix.c   | 19 ++++++--------
 include/qemu/osdep.h |  1 +
 util/osdep.c         | 72 +++++++++++++++++++++++++++++++++++++++++++++-------
 3 files changed, 72 insertions(+), 20 deletions(-)

-- 
2.13.3

             reply	other threads:[~2017-07-21 10:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21 10:20 Fam Zheng [this message]
2017-07-21 10:20 ` [Qemu-devel] [PATCH 1/2] osdep: Add runtime OFD lock detection Fam Zheng
2017-07-21 12:30   ` Eric Blake
2017-07-21 10:20 ` [Qemu-devel] [PATCH 2/2] file-posix: Do runtime check for ofd lock API Fam Zheng
2017-07-21 12:36   ` Eric Blake
2017-08-10  8:16     ` Christian Ehrhardt
2017-07-21 17:23   ` Andrew Baumann
2017-07-21 11:56 ` [Qemu-devel] [PATCH 0/2] block: Do OFD lock check at runtime Kevin Wolf
2017-07-21 12:34   ` Eric Blake
2017-07-21 13:47     ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170721102059.14663-1-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=Andrew.Baumann@microsoft.com \
    --cc=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).