* [Qemu-devel] [PATCH] io: fix temp directory used by test-io-channel-tls test
@ 2017-07-21 11:49 Daniel P. Berrange
2017-07-21 11:53 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 2+ messages in thread
From: Daniel P. Berrange @ 2017-07-21 11:49 UTC (permalink / raw)
To: qemu-devel; +Cc: Dr . David Alan Gilbert, Daniel P. Berrange
The test-io-channel-tls test was mistakenly using two of the
same directories as test-crypto-tlssession. This causes a
sporadic failure when using make -j$BIGNUM.
Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
tests/test-io-channel-tls.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/test-io-channel-tls.c b/tests/test-io-channel-tls.c
index 8eaa208e1b..ff96877323 100644
--- a/tests/test-io-channel-tls.c
+++ b/tests/test-io-channel-tls.c
@@ -127,8 +127,8 @@ static void test_io_channel_tls(const void *opaque)
/* We'll use this for our fake client-server connection */
g_assert(socketpair(AF_UNIX, SOCK_STREAM, 0, channel) == 0);
-#define CLIENT_CERT_DIR "tests/test-crypto-tlssession-client/"
-#define SERVER_CERT_DIR "tests/test-crypto-tlssession-server/"
+#define CLIENT_CERT_DIR "tests/test-io-channel-tls-client/"
+#define SERVER_CERT_DIR "tests/test-io-channel-tls-server/"
mkdir(CLIENT_CERT_DIR, 0700);
mkdir(SERVER_CERT_DIR, 0700);
--
2.13.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] io: fix temp directory used by test-io-channel-tls test
2017-07-21 11:49 [Qemu-devel] [PATCH] io: fix temp directory used by test-io-channel-tls test Daniel P. Berrange
@ 2017-07-21 11:53 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 2+ messages in thread
From: Dr. David Alan Gilbert @ 2017-07-21 11:53 UTC (permalink / raw)
To: Daniel P. Berrange; +Cc: qemu-devel
* Daniel P. Berrange (berrange@redhat.com) wrote:
> The test-io-channel-tls test was mistakenly using two of the
> same directories as test-crypto-tlssession. This causes a
> sporadic failure when using make -j$BIGNUM.
>
> Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> tests/test-io-channel-tls.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/test-io-channel-tls.c b/tests/test-io-channel-tls.c
> index 8eaa208e1b..ff96877323 100644
> --- a/tests/test-io-channel-tls.c
> +++ b/tests/test-io-channel-tls.c
> @@ -127,8 +127,8 @@ static void test_io_channel_tls(const void *opaque)
> /* We'll use this for our fake client-server connection */
> g_assert(socketpair(AF_UNIX, SOCK_STREAM, 0, channel) == 0);
>
> -#define CLIENT_CERT_DIR "tests/test-crypto-tlssession-client/"
> -#define SERVER_CERT_DIR "tests/test-crypto-tlssession-server/"
> +#define CLIENT_CERT_DIR "tests/test-io-channel-tls-client/"
> +#define SERVER_CERT_DIR "tests/test-io-channel-tls-server/"
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> mkdir(CLIENT_CERT_DIR, 0700);
> mkdir(SERVER_CERT_DIR, 0700);
>
> --
> 2.13.3
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-21 11:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-21 11:49 [Qemu-devel] [PATCH] io: fix temp directory used by test-io-channel-tls test Daniel P. Berrange
2017-07-21 11:53 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).