qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, dgilbert@redhat.com, armbru@redhat.com,
	vsementsov@virtuozzo.com, den@openvz.org
Subject: [Qemu-devel] [PATCH 0/2] improve tracing
Date: Fri, 21 Jul 2017 17:31:47 +0300	[thread overview]
Message-ID: <20170721143149.43721-1-vsementsov@virtuozzo.com> (raw)

Current trace system have a drawback: parameters of trace functions
are calculated even if corresponding tracepoint is disabled. Also, it
looks like trace function are not actually inlined by compiler (at
least for me).

Here is a fix proposal: move from function call to macros. Patch 02
is an example, of how to reduce extra calculations with help of
patch 01.

Vladimir Sementsov-Ogievskiy (2):
  trace: do not calculate arguments for disabled trace-points
  monitor: improve tracing in handle_qmp_command

 monitor.c                     |  6 +++---
 scripts/tracetool/format/h.py | 13 +++++++------
 2 files changed, 10 insertions(+), 9 deletions(-)

-- 
2.11.1

             reply	other threads:[~2017-07-21 14:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21 14:31 Vladimir Sementsov-Ogievskiy [this message]
2017-07-21 14:31 ` [Qemu-devel] [PATCH 1/2] trace: do not calculate arguments for disabled trace-points Vladimir Sementsov-Ogievskiy
2017-07-21 14:31 ` [Qemu-devel] [PATCH 2/2] monitor: improve tracing in handle_qmp_command Vladimir Sementsov-Ogievskiy
2017-07-24 11:39   ` Stefan Hajnoczi
2017-07-21 17:04 ` [Qemu-devel] [PATCH 0/2] improve tracing Lluís Vilanova
2017-07-24  8:55   ` Vladimir Sementsov-Ogievskiy
2017-07-24 11:07     ` Lluís Vilanova
2017-07-24 11:16       ` Denis V. Lunev
2017-07-24 11:32   ` Stefan Hajnoczi
2017-07-24 11:34 ` Stefan Hajnoczi
2017-07-24 12:17   ` Denis V. Lunev
2017-07-24 14:43     ` Lluís Vilanova
2017-07-24 14:55       ` Denis V. Lunev
2017-07-24 16:32         ` Lluís Vilanova
2017-07-25 13:52           ` Stefan Hajnoczi
2017-07-24 16:24     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170721143149.43721-1-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).