From: <peng.hao2@zte.com.cn>
To: mst@redhat.com
Cc: imammedo@redhat.com, dgilbert@redhat.com,
marcandre.lureau@redhat.com, maxime.coquelin@redhat.com,
wang.yechao255@zte.com.cn, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vhost: fix amigration failedbecause ofvhost region merge
Date: Sun, 23 Jul 2017 11:54:59 +0800 (CST) [thread overview]
Message-ID: <201707231154592281234@zte.com.cn> (raw)
> On Sat, Jul 22, 2017 at 01:49:20PM +0800, peng.hao2@zte.com.cn wrote:
> > some regions can not merge when just part of devices have realized.
> >
> > when all devices are realized on destination, these regions can be merged
> > again
> >
> > and the used slots can satisfy the vhost slot limit as on source.
> >
> > in the restore stage the vm is not in running state, so don't compute if more
> > than
> >
> > vhost slot limit when vm is not running. when a last device is realized,
> >
> > all regions are merged to the slot number as on source. then the state of vm
> >
> > changes to running.
> >
> > it satisfies the vhost slot limit on source, so it should satify on
> > destination.
> OK but the VM not running check is too hacky. E.g. it won't
> trigger with memory hotplug if someone stops VM before
> doing hotplug.
> Looks like you want to check machine_init_done or something
> like this.
Yeah, it sounds better.I will make anther patch.
--
> MST
reply other threads:[~2017-07-23 3:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201707231154592281234@zte.com.cn \
--to=peng.hao2@zte.com.cn \
--cc=dgilbert@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wang.yechao255@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).