qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* Re: [Qemu-devel] [PATCH] vhost: fix amigration failedbecause ofvhost region merge
@ 2017-07-23  3:54 peng.hao2
  0 siblings, 0 replies; only message in thread
From: peng.hao2 @ 2017-07-23  3:54 UTC (permalink / raw)
  To: mst
  Cc: imammedo, dgilbert, marcandre.lureau, maxime.coquelin,
	wang.yechao255, qemu-devel

> On Sat, Jul 22, 2017 at 01:49:20PM +0800, peng.hao2@zte.com.cn wrote:



> > some regions can not merge when just part of devices have realized.
> > 
> > when all devices are realized on destination, these regions  can be merged
> >  again 
> > 
> >  and the used slots can satisfy the vhost slot limit as on source.
> > 
> > in the restore stage the vm is not in running state, so don't compute if more
> > than 
> > 
> > vhost slot limit when vm is not running. when a last device is realized,
> > 
> > all regions are merged to the slot number as on source. then the state of vm 
> > 
> > changes to running.
> > 
> >  it satisfies the vhost slot limit on source, so it should satify on
> > destination.

> OK but the VM not running check is too hacky. E.g. it won't
> trigger with memory hotplug if someone stops VM before
> doing hotplug.

> Looks like you want to check machine_init_done or something
> like this.
Yeah, it sounds better.I will make anther patch.
-- 
> MST

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-07-23  3:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-23  3:54 [Qemu-devel] [PATCH] vhost: fix amigration failedbecause ofvhost region merge peng.hao2

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).