* Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: Remove a few tests from 'quick' group
2017-07-17 14:26 [Qemu-devel] [PATCH] iotests: Remove a few tests from 'quick' group Eric Blake
@ 2017-07-17 18:07 ` John Snow
2017-07-18 17:00 ` Jeff Cody
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: John Snow @ 2017-07-17 18:07 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: Kevin Wolf, berrange, stefanha, qemu-block, mreitz
On 07/17/2017 10:26 AM, Eric Blake wrote:
> A run of './check -qcow2 -g quick' on my machine produced only
> two tests that took longer than 5 seconds; 178 took 18, and
> 189 took 7. Remove them from the quick group.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> tests/qemu-iotests/group | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index 2aba585287..01f12d6781 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -175,11 +175,11 @@
> 175 auto quick
> 176 rw auto backing
> 177 rw auto quick
> -178 auto quick
> +178 auto
> 179 rw auto quick
> 181 rw auto migration
> 182 rw auto quick
> 183 rw auto migration
> 185 rw auto
> 188 rw auto quick
> -189 rw auto quick
> +189 rw auto
>
Seems about as scientific as the existing methods used to define the
quick group, so why not?
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: Remove a few tests from 'quick' group
2017-07-17 14:26 [Qemu-devel] [PATCH] iotests: Remove a few tests from 'quick' group Eric Blake
2017-07-17 18:07 ` [Qemu-devel] [Qemu-block] " John Snow
@ 2017-07-18 17:00 ` Jeff Cody
2017-07-20 12:48 ` [Qemu-devel] " Stefan Hajnoczi
2017-07-24 8:59 ` Kevin Wolf
3 siblings, 0 replies; 5+ messages in thread
From: Jeff Cody @ 2017-07-18 17:00 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, Kevin Wolf, berrange, stefanha, qemu-block, mreitz
On Mon, Jul 17, 2017 at 09:26:20AM -0500, Eric Blake wrote:
> A run of './check -qcow2 -g quick' on my machine produced only
> two tests that took longer than 5 seconds; 178 took 18, and
> 189 took 7. Remove them from the quick group.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> tests/qemu-iotests/group | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index 2aba585287..01f12d6781 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -175,11 +175,11 @@
> 175 auto quick
> 176 rw auto backing
> 177 rw auto quick
> -178 auto quick
> +178 auto
> 179 rw auto quick
> 181 rw auto migration
> 182 rw auto quick
> 183 rw auto migration
> 185 rw auto
> 188 rw auto quick
> -189 rw auto quick
> +189 rw auto
> --
> 2.13.3
>
>
Reviewed-by: Jeff Cody <jcody@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] iotests: Remove a few tests from 'quick' group
2017-07-17 14:26 [Qemu-devel] [PATCH] iotests: Remove a few tests from 'quick' group Eric Blake
2017-07-17 18:07 ` [Qemu-devel] [Qemu-block] " John Snow
2017-07-18 17:00 ` Jeff Cody
@ 2017-07-20 12:48 ` Stefan Hajnoczi
2017-07-24 8:59 ` Kevin Wolf
3 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2017-07-20 12:48 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, qemu-block, mreitz, berrange, Kevin Wolf
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
On Mon, Jul 17, 2017 at 09:26:20AM -0500, Eric Blake wrote:
> A run of './check -qcow2 -g quick' on my machine produced only
> two tests that took longer than 5 seconds; 178 took 18, and
> 189 took 7. Remove them from the quick group.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> tests/qemu-iotests/group | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] iotests: Remove a few tests from 'quick' group
2017-07-17 14:26 [Qemu-devel] [PATCH] iotests: Remove a few tests from 'quick' group Eric Blake
` (2 preceding siblings ...)
2017-07-20 12:48 ` [Qemu-devel] " Stefan Hajnoczi
@ 2017-07-24 8:59 ` Kevin Wolf
3 siblings, 0 replies; 5+ messages in thread
From: Kevin Wolf @ 2017-07-24 8:59 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, qemu-block, mreitz, stefanha, berrange
Am 17.07.2017 um 16:26 hat Eric Blake geschrieben:
> A run of './check -qcow2 -g quick' on my machine produced only
> two tests that took longer than 5 seconds; 178 took 18, and
> 189 took 7. Remove them from the quick group.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread