qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amador Pahim <apahim@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, berrange@redhat.com, ehabkost@redhat.com,
	mreitz@redhat.com, kwolf@redhat.com, armbru@redhat.com,
	crosa@redhat.com, ldoktor@redhat.com,
	Amador Pahim <apahim@redhat.com>
Subject: [Qemu-devel] [PATCH v4 0/2] scripts/qemu.py fixes and cleanups
Date: Mon, 24 Jul 2017 14:44:36 +0200	[thread overview]
Message-ID: <20170724124438.27344-1-apahim@redhat.com> (raw)

First commit renames self._args to self.args. The leading underscore
represents that the variable is private and as such it should not be
accessed externally. But that variable is the main API for inclusion
of Qemu command arguments, so the rename makes it public.

Second commit contains some fixes and cleanups to make sure we are
correctly trying to launch the VM and properly shutting it down. More
details about the changes in the commit message.

Changes v1->v2:
 - Style fixes to make checkpatch.pl happy.
 - Rebased.
Changes v2->v3:
 - Fix typo in patch 3 ("qemu.py: make 'args' public") commit message.
Changes v3->v4:
 - Squash the 2 first commits since they are co-dependant.
 - Cleanup launch() and shutdown().
 - Reorder the commits, putting the rename of self._args first.
 - Rebased.

Amador Pahim (2):
  qemu.py: make 'args' public
  qemu.py: cleanup and fixes

 scripts/qemu.py               | 79 ++++++++++++++++++++++++++++---------------
 tests/qemu-iotests/iotests.py | 18 +++++-----
 2 files changed, 60 insertions(+), 37 deletions(-)

-- 
2.13.3

             reply	other threads:[~2017-07-24 12:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 12:44 Amador Pahim [this message]
2017-07-24 12:44 ` [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public Amador Pahim
2017-07-25 13:37   ` Stefan Hajnoczi
2017-07-25 14:41     ` Amador Pahim
2017-07-25 15:30     ` Cleber Rosa
2017-07-26 17:35       ` Stefan Hajnoczi
2017-07-26 18:34         ` Cleber Rosa
2017-07-27  7:39         ` Amador Pahim
2017-07-27 15:15           ` Amador Pahim
2017-07-24 12:44 ` [Qemu-devel] [PATCH v4 2/2] qemu.py: cleanup and fixes Amador Pahim
2017-07-25 13:45   ` Stefan Hajnoczi
2017-07-25 14:45     ` Amador Pahim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170724124438.27344-1-apahim@redhat.com \
    --to=apahim@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=ldoktor@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).