Re: [Qemu-devel] [PATCH 1/7] block: move ThrottleGroup membership to ThrottleGroupMember

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

On Fri, Jul 14, 2017 at 12:45:15PM +0300, Manos Pitsidianakis wrote:
> This commit eliminates the 1:1 relationship between BlockBackend and
> throttle group state.  Users will be able to create multiple throttle
> nodes, each with its own throttle group state, in the future.  The
> throttle group state cannot be per-BlockBackend anymore, it must be
> per-throttle node. This is done by gathering ThrottleGroup membership
> details from BlockBackendPublic into ThrottleGroupMember and refactoring
> existing code to use the structure.
> 
> Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
> ---
> 
> Notes:
>     Dropped R-b because I changed some of the comments (removed all BlockBackend
>         references in block/throttle-groups.c comments)
> 
>  block/block-backend.c           |  66 +++++----
>  block/qapi.c                    |   8 +-
>  block/throttle-groups.c         | 288 ++++++++++++++++++++--------------------
>  blockdev.c                      |   4 +-
>  include/block/throttle-groups.h |  39 +++++-
>  include/sysemu/block-backend.h  |  20 +--
>  tests/test-throttle.c           |  53 ++++----
>  7 files changed, 252 insertions(+), 226 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]