From: "Lukáš Doktor" <ldoktor@redhat.com>
To: qemu-devel@nongnu.org
Cc: ldoktor@redhat.com, famz@redhat.com, ehabkost@redhat.com,
apahim@redhat.com, mreitz@redhat.com, f4bug@amsat.org,
armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 03/10] qemu.py: Use iteritems rather than keys()
Date: Tue, 25 Jul 2017 17:09:44 +0200 [thread overview]
Message-ID: <20170725150951.16038-4-ldoktor@redhat.com> (raw)
In-Reply-To: <20170725150951.16038-1-ldoktor@redhat.com>
Let's avoid creating an in-memory list of keys and query for each value
and use `iteritems` which is an iterator of key-value pairs.
Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
scripts/qemu.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 66fd863..7e95c25 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -185,11 +185,11 @@ class QEMUMachine(object):
def qmp(self, cmd, conv_keys=True, **args):
'''Invoke a QMP command and return the result dict'''
qmp_args = dict()
- for key in args.keys():
+ for key, value in args.iteritems():
if conv_keys:
- qmp_args[key.translate(self.underscore_to_dash)] = args[key]
+ qmp_args[key.translate(self.underscore_to_dash)] = value
else:
- qmp_args[key] = args[key]
+ qmp_args[key] = value
return self._qmp.cmd(cmd, args=qmp_args)
--
2.9.4
next prev parent reply other threads:[~2017-07-25 15:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 15:09 [Qemu-devel] [PATCH v2 00/10] qemu.py: Pylint/style fixes Lukáš Doktor
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 01/10] " Lukáš Doktor
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 02/10] qemu|qtest: Avoid dangerous arguments Lukáš Doktor
2017-07-25 17:14 ` John Snow
2017-07-25 15:09 ` Lukáš Doktor [this message]
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 04/10] qemu.py: Simplify QMP key-conversion Lukáš Doktor
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 05/10] qemu.py: Use custom exceptions rather than Exception Lukáš Doktor
2017-07-25 16:06 ` Eduardo Habkost
2017-07-26 4:39 ` Lukáš Doktor
2017-07-26 13:00 ` Eduardo Habkost
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 06/10] qmp.py: Couple of pylint/style fixes Lukáš Doktor
2017-07-25 15:18 ` Philippe Mathieu-Daudé
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 07/10] qmp.py: Use object-based class for QEMUMonitorProtocol Lukáš Doktor
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 08/10] qmp.py: Avoid "has_key" usage Lukáš Doktor
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 09/10] qmp.py: Avoid overriding a builtin object Lukáš Doktor
2017-07-25 19:34 ` Eduardo Habkost
2017-07-26 4:46 ` Lukáš Doktor
2017-07-26 13:01 ` Eduardo Habkost
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 10/10] qtest.py: Few pylint/style fixes Lukáš Doktor
2017-07-25 17:19 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725150951.16038-4-ldoktor@redhat.com \
--to=ldoktor@redhat.com \
--cc=apahim@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).