From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1da25F-0003Fr-Uj for qemu-devel@nongnu.org; Tue, 25 Jul 2017 11:49:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1da25E-0007BF-Ps for qemu-devel@nongnu.org; Tue, 25 Jul 2017 11:49:17 -0400 Date: Tue, 25 Jul 2017 16:48:54 +0100 From: "Daniel P. Berrange" Message-ID: <20170725154854.GS26394@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170721034730.25612-1-crosa@redhat.com> <20170721034730.25612-4-crosa@redhat.com> <20170725154546.GR23343@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170725154546.GR23343@stefanha-x1.localdomain> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] qemu-iotests: require CONFIG_LINUX_AIO for test 087 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Jing Liu , Cleber Rosa , qemu-devel@nongnu.org, Kevin Wolf , qemu-block@nongnu.org, Max Reitz On Tue, Jul 25, 2017 at 04:45:46PM +0100, Stefan Hajnoczi wrote: > On Mon, Jul 24, 2017 at 02:44:13PM +0800, Jing Liu wrote: > > On 2017/7/21 =E4=B8=8A=E5=8D=8811:47, Cleber Rosa wrote: > > > One of the "sub-"tests of test 087 requires CONFIG_LINUX_AIO. > > >=20 > > > As a PoC/RFC, this goes the easy route and skips the test as a whol= e > > > when that feature is missing. Other approaches include splitting > > > the test and adding extra filtering. > > >=20 > > > Signed-off-by: Cleber Rosa > > > --- > > > tests/qemu-iotests/087 | 1 + > > > 1 file changed, 1 insertion(+) > > >=20 > > > diff --git a/tests/qemu-iotests/087 b/tests/qemu-iotests/087 > > > index f8e4903..a2fb7de 100755 > > > --- a/tests/qemu-iotests/087 > > > +++ b/tests/qemu-iotests/087 > > > @@ -34,6 +34,7 @@ status=3D1 # failure is the default! > > > _supported_fmt qcow2 > > > _supported_proto file > > > _supported_os Linux > > > +_require_feature CONFIG_LINUX_AIO > > I tested that CONFIG_NETTLE_KDF is also a necessary for 087. > >=20 > > +_require_feature CONFIG_NETTLE_KDF >=20 > Are you sure? Looks like either nettle or gcrypt is needed: Correct, it works with either. > crypto/Makefile.objs:crypto-obj-$(CONFIG_NETTLE_KDF) +=3D pbkdf-nettle.= o > crypto/Makefile.objs:crypto-obj-$(if $(CONFIG_NETTLE_KDF),n,$(CONFIG_GC= RYPT_KDF)) +=3D pbkdf-gcrypt.o >=20 > But this shows why the compile-time testing of features is ugly: >=20 > 1. It duplicates build dependency logic into the test cases. >=20 > 2. The test cases don't care about nettle vs gcrypt and they shouldn't > have to know about it. They just care whether LUKS is available or > not. Yeah that knowledge is messy and fragile wrt future changes. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|