qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amador Pahim <apahim@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, famz@redhat.com, berrange@redhat.com,
	ehabkost@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
	armbru@redhat.com, crosa@redhat.com, ldoktor@redhat.com,
	Amador Pahim <apahim@redhat.com>
Subject: [Qemu-devel] [PATCH v5 2/6] qemu.py: use poll() instead of 'returncode'
Date: Tue, 25 Jul 2017 19:10:10 +0200	[thread overview]
Message-ID: <20170725171014.25193-3-apahim@redhat.com> (raw)
In-Reply-To: <20170725171014.25193-1-apahim@redhat.com>

The 'returncode' Popen attribute is not guaranteed to be updated. It
actually depends on a call to either poll(), wait() or communicate().

On the other hand, poll() will "Check if child process has terminated.
Set and return returncode attribute."

Let's use the poll() to check whether the process is running and also
to get the updated process exit code, if any.

Signed-off-by: Amador Pahim <apahim@redhat.com>
---
 scripts/qemu.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/qemu.py b/scripts/qemu.py
index 59ed5270f8..f37e2fe58e 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -86,12 +86,12 @@ class QEMUMachine(object):
             raise
 
     def is_running(self):
-        return self._popen and (self._popen.returncode is None)
+        return self._popen and (self._popen.poll() is None)
 
     def exitcode(self):
         if self._popen is None:
             return None
-        return self._popen.returncode
+        return self._popen.poll()
 
     def get_pid(self):
         if not self.is_running():
-- 
2.13.3

  parent reply	other threads:[~2017-07-25 17:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 17:10 [Qemu-devel] [PATCH v5 0/6] scripts/qemu.py fixes and cleanups Amador Pahim
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 1/6] qemu.py: make 'args' public Amador Pahim
2017-07-27 14:18   ` Stefan Hajnoczi
2017-07-27 14:59     ` Amador Pahim
2017-07-25 17:10 ` Amador Pahim [this message]
2017-07-27 14:11   ` [Qemu-devel] [PATCH v5 2/6] qemu.py: use poll() instead of 'returncode' Stefan Hajnoczi
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 3/6] qemu.py: cleanup message on negative exit code Amador Pahim
2017-07-25 19:08   ` Cleber Rosa
2017-07-25 19:51   ` Eduardo Habkost
2017-07-27  8:21     ` Amador Pahim
2017-07-30 20:24       ` Eduardo Habkost
2017-07-27 14:12   ` Stefan Hajnoczi
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 4/6] qemu.py: cleanup launch() Amador Pahim
2017-07-25 19:17   ` Cleber Rosa
2017-07-25 20:42   ` Eduardo Habkost
2017-07-27  7:56     ` Amador Pahim
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 5/6] qemu.py: make sure shutdown() is called before launching again Amador Pahim
2017-07-25 19:58   ` Eduardo Habkost
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 6/6] qemu.py: include qemu command line and output on launch error Amador Pahim
2017-07-25 21:17   ` Eduardo Habkost
2017-07-27  8:01     ` Amador Pahim
2017-07-27 13:31 ` [Qemu-devel] [PATCH v5 0/6] scripts/qemu.py fixes and cleanups no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170725171014.25193-3-apahim@redhat.com \
    --to=apahim@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=ldoktor@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).