qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amador Pahim <apahim@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, famz@redhat.com, berrange@redhat.com,
	ehabkost@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
	armbru@redhat.com, crosa@redhat.com, ldoktor@redhat.com,
	Amador Pahim <apahim@redhat.com>
Subject: [Qemu-devel] [PATCH v5 3/6] qemu.py: cleanup message on negative exit code
Date: Tue, 25 Jul 2017 19:10:11 +0200	[thread overview]
Message-ID: <20170725171014.25193-4-apahim@redhat.com> (raw)
In-Reply-To: <20170725171014.25193-1-apahim@redhat.com>

The message contains the self._args, which has only part of the
options used in the qemu command line and is not representative
enough to figure out what happened to the process.

This patch drops the self._args part of the message.

Signed-off-by: Amador Pahim <apahim@redhat.com>
---
 scripts/qemu.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/qemu.py b/scripts/qemu.py
index f37e2fe58e..56142ed59b 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -154,7 +154,8 @@ class QEMUMachine(object):
 
             exitcode = self._popen.wait()
             if exitcode < 0:
-                sys.stderr.write('qemu received signal %i: %s\n' % (-exitcode, ' '.join(self.args)))
+                sys.stderr.write('qemu received signal %i\n' % -exitcode)
+
             self._load_io_log()
             self._post_shutdown()
 
-- 
2.13.3

  parent reply	other threads:[~2017-07-25 17:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 17:10 [Qemu-devel] [PATCH v5 0/6] scripts/qemu.py fixes and cleanups Amador Pahim
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 1/6] qemu.py: make 'args' public Amador Pahim
2017-07-27 14:18   ` Stefan Hajnoczi
2017-07-27 14:59     ` Amador Pahim
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 2/6] qemu.py: use poll() instead of 'returncode' Amador Pahim
2017-07-27 14:11   ` Stefan Hajnoczi
2017-07-25 17:10 ` Amador Pahim [this message]
2017-07-25 19:08   ` [Qemu-devel] [PATCH v5 3/6] qemu.py: cleanup message on negative exit code Cleber Rosa
2017-07-25 19:51   ` Eduardo Habkost
2017-07-27  8:21     ` Amador Pahim
2017-07-30 20:24       ` Eduardo Habkost
2017-07-27 14:12   ` Stefan Hajnoczi
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 4/6] qemu.py: cleanup launch() Amador Pahim
2017-07-25 19:17   ` Cleber Rosa
2017-07-25 20:42   ` Eduardo Habkost
2017-07-27  7:56     ` Amador Pahim
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 5/6] qemu.py: make sure shutdown() is called before launching again Amador Pahim
2017-07-25 19:58   ` Eduardo Habkost
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 6/6] qemu.py: include qemu command line and output on launch error Amador Pahim
2017-07-25 21:17   ` Eduardo Habkost
2017-07-27  8:01     ` Amador Pahim
2017-07-27 13:31 ` [Qemu-devel] [PATCH v5 0/6] scripts/qemu.py fixes and cleanups no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170725171014.25193-4-apahim@redhat.com \
    --to=apahim@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=ldoktor@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).