From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, rth@twiddle.net,
Aurelien Jarno <aurelien@aurel32.net>,
thuth@redhat.com, borntraeger@de.ibm.com
Subject: Re: [Qemu-devel] [PATCH v1 2/6] target/s390x: fix pgm irq ilen in translate_pages()
Date: Tue, 25 Jul 2017 17:39:16 +0200 [thread overview]
Message-ID: <20170725173916.627fdd97@gondolin> (raw)
In-Reply-To: <20170721125609.11117-3-david@redhat.com>
On Fri, 21 Jul 2017 14:56:05 +0200
David Hildenbrand <david@redhat.com> wrote:
> 0 is certainly wrong. Let's use ILEN_AUTO.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/mmu_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
> index a873dc4..1ad0158 100644
> --- a/target/s390x/mmu_helper.c
> +++ b/target/s390x/mmu_helper.c
> @@ -440,7 +440,7 @@ static int translate_pages(S390CPU *cpu, vaddr addr, int nr_pages,
> }
> if (!address_space_access_valid(&address_space_memory, pages[i],
> TARGET_PAGE_SIZE, is_write)) {
> - program_interrupt(env, PGM_ADDRESSING, 0);
> + program_interrupt(env, PGM_ADDRESSING, ILEN_AUTO);
> return -EFAULT;
> }
> addr += TARGET_PAGE_SIZE;
Thanks, applied.
next prev parent reply other threads:[~2017-07-25 15:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 12:56 [Qemu-devel] [PATCH v1 0/6] target/s390x: tcg improvments + MSA functions David Hildenbrand
2017-07-21 12:56 ` [Qemu-devel] [PATCH v1 1/6] target/s390x: fix pgm irq ilen for stsi David Hildenbrand
2017-07-24 14:23 ` Thomas Huth
2017-07-25 15:38 ` Cornelia Huck
2017-07-21 12:56 ` [Qemu-devel] [PATCH v1 2/6] target/s390x: fix pgm irq ilen in translate_pages() David Hildenbrand
2017-07-24 14:37 ` Thomas Huth
2017-07-25 15:39 ` Cornelia Huck [this message]
2017-07-21 12:56 ` [Qemu-devel] [PATCH v1 3/6] target/s390x: implement spm (SET PROGRAM MASK) David Hildenbrand
2017-07-24 4:39 ` Richard Henderson
2017-07-24 17:25 ` David Hildenbrand
2017-07-21 12:56 ` [Qemu-devel] [PATCH v1 4/6] target/s390x: move wrap_address to cpu.h David Hildenbrand
2017-07-24 4:40 ` Richard Henderson
2017-07-24 17:38 ` David Hildenbrand
2017-07-24 18:00 ` Richard Henderson
2017-07-24 18:00 ` David Hildenbrand
2017-07-21 12:56 ` [Qemu-devel] [PATCH v1 5/6] target/s390x: add basic MSA features David Hildenbrand
2017-08-09 13:01 ` Cornelia Huck
2017-08-09 13:13 ` Thomas Huth
2017-08-09 13:25 ` David Hildenbrand
2017-08-09 13:29 ` Cornelia Huck
2017-07-21 12:56 ` [Qemu-devel] [PATCH v1 6/6] target/s390x: various alignment check David Hildenbrand
2017-07-21 13:26 ` [Qemu-devel] [PATCH v1 0/6] target/s390x: tcg improvments + MSA functions no-reply
2017-07-24 3:16 ` Richard Henderson
2017-07-24 17:58 ` David Hildenbrand
2017-07-25 11:55 ` Cornelia Huck
2017-07-25 12:16 ` David Hildenbrand
2017-07-25 12:45 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725173916.627fdd97@gondolin \
--to=cohuck@redhat.com \
--cc=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).