qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Lukáš Doktor" <ldoktor@redhat.com>
To: qemu-devel@nongnu.org
Cc: ldoktor@redhat.com, famz@redhat.com, ehabkost@redhat.com,
	apahim@redhat.com, armbru@redhat.com, mreitz@redhat.com,
	jsnow@redhat.com, f4bug@amsat.org
Subject: [Qemu-devel] [PATCH v4 00/10] qemu.py: Pylint/style fixes
Date: Wed, 26 Jul 2017 16:42:16 +0200	[thread overview]
Message-ID: <20170726144226.6913-1-ldoktor@redhat.com> (raw)

Hello guys,

I'm reading the available python modules to exercise qemu and while reading them
I fixed some issues that caught my attention. It usually starts with a simple
pylint/docstring fixes and slowly graduates to more controversial ones so I'm
open to suggestion to remove some of them.

Kind regards,
Lukáš

Changes v1->v2
 - Squashed 2nd and 10th patches into 2nd one
 - Use repr() in MonitorResponseError's description
 - Improved commit message of the 6th patch
 - Two tweaks to docstrings changed in the 6th patch
 - Also updated qmp-shell to use new-style super calls (7th patch)
 - Fixed the accidental rename of qmp `cmd_id` (kept the id->cmd_id patch)
 - Changed the style of the style-fix in the 10th commit

Changes v2->v3
 - Don't use repr in the 5th patch in MonitorResponseError

Changes v3->v4
 - Use correct git base (remove unwanted commits)

Lukáš Doktor (10):
  qemu.py: Pylint/style fixes
  qemu|qtest: Avoid dangerous arguments
  qemu.py: Use iteritems rather than keys()
  qemu.py: Simplify QMP key-conversion
  qemu.py: Use custom exceptions rather than Exception
  qmp.py: Couple of pylint/style fixes
  qmp.py: Use object-based class for QEMUMonitorProtocol
  qmp.py: Avoid "has_key" usage
  qmp.py: Avoid overriding a builtin object
  qtest.py: Few pylint/style fixes

 scripts/qemu.py       | 98 +++++++++++++++++++++++++++++++++++++--------------
 scripts/qmp/qmp-shell |  4 +--
 scripts/qmp/qmp.py    | 49 ++++++++++++++++----------
 scripts/qtest.py      | 13 ++++---
 4 files changed, 109 insertions(+), 55 deletions(-)

-- 
2.9.4

             reply	other threads:[~2017-07-26 14:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26 14:42 Lukáš Doktor [this message]
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 01/10] qemu.py: Pylint/style fixes Lukáš Doktor
2017-08-03  7:41   ` Lukáš Doktor
2017-08-08 12:38   ` Stefan Hajnoczi
2017-08-08 12:56     ` Lukáš Doktor
2017-08-09 10:26       ` Stefan Hajnoczi
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 02/10] qemu|qtest: Avoid dangerous arguments Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 03/10] qemu.py: Use iteritems rather than keys() Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 04/10] qemu.py: Simplify QMP key-conversion Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 05/10] qemu.py: Use custom exceptions rather than Exception Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 06/10] qmp.py: Couple of pylint/style fixes Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 07/10] qmp.py: Use object-based class for QEMUMonitorProtocol Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 08/10] qmp.py: Avoid "has_key" usage Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 09/10] qmp.py: Avoid overriding a builtin object Lukáš Doktor
2017-07-26 14:42 ` [Qemu-devel] [PATCH v4 10/10] qtest.py: Few pylint/style fixes Lukáš Doktor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170726144226.6913-1-ldoktor@redhat.com \
    --to=ldoktor@redhat.com \
    --cc=apahim@redhat.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).