From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daSxI-0005Yo-Qg for qemu-devel@nongnu.org; Wed, 26 Jul 2017 16:30:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daSxF-0000Zk-Mw for qemu-devel@nongnu.org; Wed, 26 Jul 2017 16:30:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34910) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1daSxF-0000ZY-GF for qemu-devel@nongnu.org; Wed, 26 Jul 2017 16:30:49 -0400 Date: Wed, 26 Jul 2017 23:30:45 +0300 From: "Michael S. Tsirkin" Message-ID: <20170726232652-mutt-send-email-mst@kernel.org> References: <20170726093136.13627-1-pbonzini@redhat.com> <20170726155118-mutt-send-email-mst@kernel.org> <20170726225402-mutt-send-email-mst@kernel.org> <2080482614.19250435.1501100681184.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2080482614.19250435.1501100681184.JavaMail.zimbra@redhat.com> Subject: Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Kevin O'Connor , seabios@seabios.org, lersek@redhat.com, lists@philjordan.eu, imammedo@redhat.com, phil@philjordan.eu, programmingkidx@gmail.com, kraxel@redhat.com On Wed, Jul 26, 2017 at 04:24:41PM -0400, Paolo Bonzini wrote: > > > The point is that for PC we really should not keep piling up hacks, > > compatibility is more important. > > Non-explosion of the test matrix is just as important. Absolutely. > > > Doing it for PC only would mean switching > > > back from FADT rev3 to rev1, which is worse for guest OS support, > > > > It's only OSX AFAIK and IIRC OSX doesn't run on PC anyway. > > Sure it does. You can run it on VMware Workstation which emulates > some i440FX-like chipset. I don't think it works on our PC though. Never tried, going by Gabriel's word though. > > It's definitely way more code. I'll change my mind if there's > > a guest that needs the new FADT. > > Then you can prepare a patch to revert the FADTv3 commit, or do the > work to make it specific to the 2.10 Q35 machine type. > > Paolo Right, Igor said he's doing that. -- MST