From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Cleber Rosa <crosa@redhat.com>
Subject: [Qemu-devel] [PATCH 1/5] configure: remove duplicate single quotes on config.log header
Date: Thu, 27 Jul 2017 08:02:06 -0400 [thread overview]
Message-ID: <20170727120210.6943-2-crosa@redhat.com> (raw)
In-Reply-To: <20170727120210.6943-1-crosa@redhat.com>
The generation of the informational header on config.log contains two
pairs of single quotes, which seems unintentional, and looks like
this:
# QEMU configure log Thu Jul 26 08:17:15 EDT 2017
# Configured with: './configure' '--target-list=x86_64-softmmu'
With this change, the quotes comprehend the entire command line:
# QEMU configure log Mon Jul 26 08:17:35 EDT 2017
# Configured with: './configure --target-list=x86_64-softmmu'
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
configure | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/configure b/configure
index 987f59b..344d6d2 100755
--- a/configure
+++ b/configure
@@ -35,9 +35,7 @@ rm -f config.log
# Print a helpful header at the top of config.log
echo "# QEMU configure log $(date)" >> config.log
-printf "# Configured with:" >> config.log
-printf " '%s'" "$0" "$@" >> config.log
-echo >> config.log
+echo "# Configured with: '$0 $@'" >> config.log
echo "#" >> config.log
print_error() {
--
2.9.4
next prev parent reply other threads:[~2017-07-27 12:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 12:02 [Qemu-devel] [PATCH 0/5] Trivial fixes and cleanups Cleber Rosa
2017-07-27 12:02 ` Cleber Rosa [this message]
2017-07-27 12:15 ` [Qemu-devel] [PATCH 1/5] configure: remove duplicate single quotes on config.log header Peter Maydell
2017-07-27 12:24 ` Eric Blake
2017-07-27 13:47 ` Cleber Rosa
2017-07-27 12:02 ` [Qemu-devel] [PATCH 2/5] qemu-iotests: get rid of _full_imgproto_details() Cleber Rosa
2017-07-27 12:02 ` [Qemu-devel] [PATCH 3/5] qemu-iotests: remove commented out variables Cleber Rosa
2017-07-28 12:15 ` Stefan Hajnoczi
2017-07-27 12:02 ` [Qemu-devel] [PATCH 4/5] qemu-iotests: remove comment about root privileges requirement Cleber Rosa
2017-07-28 12:16 ` Stefan Hajnoczi
2017-07-27 12:02 ` [Qemu-devel] [PATCH 5/5] docs: fix broken paths to docs/interop dir Cleber Rosa
2017-07-27 12:22 ` Eric Blake
2017-07-28 12:17 ` Stefan Hajnoczi
2017-07-28 12:18 ` [Qemu-devel] [PATCH 0/5] Trivial fixes and cleanups Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727120210.6943-2-crosa@redhat.com \
--to=crosa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).