From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Cleber Rosa <crosa@redhat.com>
Subject: [Qemu-devel] [PATCH 2/5] qemu-iotests: get rid of _full_imgproto_details()
Date: Thu, 27 Jul 2017 08:02:07 -0400 [thread overview]
Message-ID: <20170727120210.6943-3-crosa@redhat.com> (raw)
In-Reply-To: <20170727120210.6943-1-crosa@redhat.com>
Although this function is used, its implementation does nothing
besides echoing a variable name. There's no need to wrap this
functionality in a function, and based on the one usage it has, it's
not even required to adhere to a convention or code style.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
tests/qemu-iotests/check | 3 +--
tests/qemu-iotests/common.rc | 5 -----
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 2a55ec9..7a2e0d0 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -228,7 +228,6 @@ rm -f check.full
[ -f $TIMESTAMP_FILE ] || touch $TIMESTAMP_FILE
FULL_IMGFMT_DETAILS=`_full_imgfmt_details`
-FULL_IMGPROTO_DETAILS=`_full_imgproto_details`
FULL_HOST_DETAILS=`_full_platform_details`
#FULL_MKFS_OPTIONS=`_scratch_mkfs_options`
#FULL_MOUNT_OPTIONS=`_scratch_mount_options`
@@ -239,7 +238,7 @@ QEMU_IMG -- "$QEMU_IMG_PROG" $QEMU_IMG_OPTIONS
QEMU_IO -- "$QEMU_IO_PROG" $QEMU_IO_OPTIONS
QEMU_NBD -- "$QEMU_NBD_PROG" $QEMU_NBD_OPTIONS
IMGFMT -- $FULL_IMGFMT_DETAILS
-IMGPROTO -- $FULL_IMGPROTO_DETAILS
+IMGPROTO -- $IMGPROTO
PLATFORM -- $FULL_HOST_DETAILS
TEST_DIR -- $TEST_DIR
SOCKET_SCM_HELPER -- $SOCKET_SCM_HELPER
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
index 2548e58..e4d30ad 100644
--- a/tests/qemu-iotests/common.rc
+++ b/tests/qemu-iotests/common.rc
@@ -479,11 +479,6 @@ _full_imgfmt_details()
fi
}
-_full_imgproto_details()
-{
- echo "$IMGPROTO"
-}
-
_full_platform_details()
{
os=`uname -s`
--
2.9.4
next prev parent reply other threads:[~2017-07-27 12:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 12:02 [Qemu-devel] [PATCH 0/5] Trivial fixes and cleanups Cleber Rosa
2017-07-27 12:02 ` [Qemu-devel] [PATCH 1/5] configure: remove duplicate single quotes on config.log header Cleber Rosa
2017-07-27 12:15 ` Peter Maydell
2017-07-27 12:24 ` Eric Blake
2017-07-27 13:47 ` Cleber Rosa
2017-07-27 12:02 ` Cleber Rosa [this message]
2017-07-27 12:02 ` [Qemu-devel] [PATCH 3/5] qemu-iotests: remove commented out variables Cleber Rosa
2017-07-28 12:15 ` Stefan Hajnoczi
2017-07-27 12:02 ` [Qemu-devel] [PATCH 4/5] qemu-iotests: remove comment about root privileges requirement Cleber Rosa
2017-07-28 12:16 ` Stefan Hajnoczi
2017-07-27 12:02 ` [Qemu-devel] [PATCH 5/5] docs: fix broken paths to docs/interop dir Cleber Rosa
2017-07-27 12:22 ` Eric Blake
2017-07-28 12:17 ` Stefan Hajnoczi
2017-07-28 12:18 ` [Qemu-devel] [PATCH 0/5] Trivial fixes and cleanups Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727120210.6943-3-crosa@redhat.com \
--to=crosa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).