qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Cleber Rosa <crosa@redhat.com>
Subject: [Qemu-devel] [PATCH 3/5] qemu-iotests: remove commented out variables
Date: Thu, 27 Jul 2017 08:02:08 -0400	[thread overview]
Message-ID: <20170727120210.6943-4-crosa@redhat.com> (raw)
In-Reply-To: <20170727120210.6943-1-crosa@redhat.com>

The variables FULL_MKFS_OPTIONS and FULL_MOUNT_OPTIONS are commented
out, never used, and even refer to functions that do exist.  The last
time these were touched was around 8 years ago, so I guess it's safe
to assume outputting such information on test execution is still on the
radar.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/qemu-iotests/check | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 7a2e0d0..437ef65 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -229,8 +229,6 @@ rm -f check.full
 
 FULL_IMGFMT_DETAILS=`_full_imgfmt_details`
 FULL_HOST_DETAILS=`_full_platform_details`
-#FULL_MKFS_OPTIONS=`_scratch_mkfs_options`
-#FULL_MOUNT_OPTIONS=`_scratch_mount_options`
 
 cat <<EOF
 QEMU          -- "$QEMU_PROG" $QEMU_OPTIONS
@@ -244,8 +242,6 @@ TEST_DIR      -- $TEST_DIR
 SOCKET_SCM_HELPER -- $SOCKET_SCM_HELPER
 
 EOF
-#MKFS_OPTIONS  -- $FULL_MKFS_OPTIONS
-#MOUNT_OPTIONS -- $FULL_MOUNT_OPTIONS
 
 seq="check"
 
-- 
2.9.4

  parent reply	other threads:[~2017-07-27 12:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27 12:02 [Qemu-devel] [PATCH 0/5] Trivial fixes and cleanups Cleber Rosa
2017-07-27 12:02 ` [Qemu-devel] [PATCH 1/5] configure: remove duplicate single quotes on config.log header Cleber Rosa
2017-07-27 12:15   ` Peter Maydell
2017-07-27 12:24     ` Eric Blake
2017-07-27 13:47       ` Cleber Rosa
2017-07-27 12:02 ` [Qemu-devel] [PATCH 2/5] qemu-iotests: get rid of _full_imgproto_details() Cleber Rosa
2017-07-27 12:02 ` Cleber Rosa [this message]
2017-07-28 12:15   ` [Qemu-devel] [PATCH 3/5] qemu-iotests: remove commented out variables Stefan Hajnoczi
2017-07-27 12:02 ` [Qemu-devel] [PATCH 4/5] qemu-iotests: remove comment about root privileges requirement Cleber Rosa
2017-07-28 12:16   ` Stefan Hajnoczi
2017-07-27 12:02 ` [Qemu-devel] [PATCH 5/5] docs: fix broken paths to docs/interop dir Cleber Rosa
2017-07-27 12:22   ` Eric Blake
2017-07-28 12:17   ` Stefan Hajnoczi
2017-07-28 12:18 ` [Qemu-devel] [PATCH 0/5] Trivial fixes and cleanups Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170727120210.6943-4-crosa@redhat.com \
    --to=crosa@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).