From: Stefan Hajnoczi <stefanha@gmail.com>
To: Amador Pahim <apahim@redhat.com>
Cc: qemu-devel@nongnu.org, famz@redhat.com, berrange@redhat.com,
ehabkost@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
armbru@redhat.com, crosa@redhat.com, ldoktor@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 1/6] qemu.py: make 'args' public
Date: Thu, 27 Jul 2017 15:18:04 +0100 [thread overview]
Message-ID: <20170727141804.GJ10129@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170725171014.25193-2-apahim@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
On Tue, Jul 25, 2017 at 07:10:09PM +0200, Amador Pahim wrote:
> Let's make args public so users can extend it in instances
> without feeling like abusing the internal API.
>
> Signed-off-by: Amador Pahim <apahim@redhat.com>
> ---
> scripts/qemu.py | 14 +++++++-------
> tests/qemu-iotests/iotests.py | 18 +++++++++---------
> 2 files changed, 16 insertions(+), 16 deletions(-)
As discussed in the previous revision, I don't think this patch is
justified because all current users just need a protected field. There
are no users who need the field to be public so this change is
premature.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-07-27 14:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 17:10 [Qemu-devel] [PATCH v5 0/6] scripts/qemu.py fixes and cleanups Amador Pahim
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 1/6] qemu.py: make 'args' public Amador Pahim
2017-07-27 14:18 ` Stefan Hajnoczi [this message]
2017-07-27 14:59 ` Amador Pahim
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 2/6] qemu.py: use poll() instead of 'returncode' Amador Pahim
2017-07-27 14:11 ` Stefan Hajnoczi
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 3/6] qemu.py: cleanup message on negative exit code Amador Pahim
2017-07-25 19:08 ` Cleber Rosa
2017-07-25 19:51 ` Eduardo Habkost
2017-07-27 8:21 ` Amador Pahim
2017-07-30 20:24 ` Eduardo Habkost
2017-07-27 14:12 ` Stefan Hajnoczi
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 4/6] qemu.py: cleanup launch() Amador Pahim
2017-07-25 19:17 ` Cleber Rosa
2017-07-25 20:42 ` Eduardo Habkost
2017-07-27 7:56 ` Amador Pahim
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 5/6] qemu.py: make sure shutdown() is called before launching again Amador Pahim
2017-07-25 19:58 ` Eduardo Habkost
2017-07-25 17:10 ` [Qemu-devel] [PATCH v5 6/6] qemu.py: include qemu command line and output on launch error Amador Pahim
2017-07-25 21:17 ` Eduardo Habkost
2017-07-27 8:01 ` Amador Pahim
2017-07-27 13:31 ` [Qemu-devel] [PATCH v5 0/6] scripts/qemu.py fixes and cleanups no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727141804.GJ10129@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=apahim@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=ldoktor@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).