From: Jeff Cody <jcody@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.10 3/7] qemu-iotests/141: Fix image cleanup
Date: Fri, 28 Jul 2017 17:04:14 -0400 [thread overview]
Message-ID: <20170728210414.GD5109@localhost.localdomain> (raw)
In-Reply-To: <20170728131452.15316-4-kwolf@redhat.com>
On Fri, Jul 28, 2017 at 03:14:48PM +0200, Kevin Wolf wrote:
> qemu-iotests 141 attempted to use brace expansion to remove all images
> with a single command. However, for this to work, the braces shouldn't
> be quoted.
>
> With this fix, the tests correctly cleans up its scratch images.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/141 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/141 b/tests/qemu-iotests/141
> index 40a3405968..2f9d7b9bc2 100755
> --- a/tests/qemu-iotests/141
> +++ b/tests/qemu-iotests/141
> @@ -31,7 +31,7 @@ _cleanup()
> {
> _cleanup_qemu
> _cleanup_test_img
> - rm -f "$TEST_DIR/{b,m,o}.$IMGFMT"
> + rm -f "$TEST_DIR"/{b,m,o}.$IMGFMT
> }
> trap "_cleanup; exit \$status" 0 1 2 3 15
>
> --
> 2.13.3
>
>
Reviewed-by: Jeff Cody <jcody@redhat.com>
next prev parent reply other threads:[~2017-07-28 21:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 13:14 [Qemu-devel] [PATCH for-2.10 0/7] qemu-iotests: Fix leaked temporary file fixes Kevin Wolf
2017-07-28 13:14 ` [Qemu-devel] [PATCH for-2.10 1/7] qemu-iotests/041: Fix leaked scratch images Kevin Wolf
2017-07-28 19:28 ` Eric Blake
2017-07-28 21:34 ` Jeff Cody
2017-07-28 13:14 ` [Qemu-devel] [PATCH for-2.10 2/7] qemu-iotests: Remove blkdebug.conf after tests Kevin Wolf
2017-07-28 15:33 ` Jeff Cody
2017-07-28 19:27 ` Eric Blake
2017-07-28 13:14 ` [Qemu-devel] [PATCH for-2.10 3/7] qemu-iotests/141: Fix image cleanup Kevin Wolf
2017-07-28 21:04 ` Jeff Cody [this message]
2017-07-28 13:14 ` [Qemu-devel] [PATCH for-2.10 4/7] qemu-iotests/153: Fix leaked scratch images Kevin Wolf
2017-07-28 15:37 ` Jeff Cody
2017-07-28 13:14 ` [Qemu-devel] [PATCH for-2.10 5/7] qemu-iotests/162: Fix leaked temporary files Kevin Wolf
2017-07-28 21:18 ` Jeff Cody
2017-07-28 13:14 ` [Qemu-devel] [PATCH for-2.10 6/7] qemu-iotests/063: Fix leaked image Kevin Wolf
2017-07-28 21:21 ` Jeff Cody
2017-07-28 13:14 ` [Qemu-devel] [PATCH for-2.10 7/7] qemu-iotests/059: Fix leaked image files Kevin Wolf
2017-07-28 19:33 ` Eric Blake
2017-07-28 21:39 ` Jeff Cody
2017-07-28 19:34 ` [Qemu-devel] [PATCH for-2.10 0/7] qemu-iotests: Fix leaked temporary file fixes Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728210414.GD5109@localhost.localdomain \
--to=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).