From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dc6Qq-0006AZ-8r for qemu-devel@nongnu.org; Mon, 31 Jul 2017 04:52:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dc6Qm-0000RL-Ce for qemu-devel@nongnu.org; Mon, 31 Jul 2017 04:52:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51404) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dc6Qm-0000QV-6k for qemu-devel@nongnu.org; Mon, 31 Jul 2017 04:52:04 -0400 From: Amador Pahim Date: Mon, 31 Jul 2017 10:51:04 +0200 Message-Id: <20170731085110.1050-2-apahim@redhat.com> In-Reply-To: <20170731085110.1050-1-apahim@redhat.com> References: <20170731085110.1050-1-apahim@redhat.com> Subject: [Qemu-devel] [PATCH v6 1/7] qemu.py: use poll() instead of 'returncode' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: stefanha@gmail.com, famz@redhat.com, berrange@redhat.com, ehabkost@redhat.com, mreitz@redhat.com, kwolf@redhat.com, armbru@redhat.com, crosa@redhat.com, ldoktor@redhat.com, Amador Pahim The 'returncode' Popen attribute is not guaranteed to be updated. It actually depends on a call to either poll(), wait() or communicate(). On the other hand, poll() will: "Check if child process has terminated. Set and return returncode attribute." Let's use the poll() to check whether the process is running and also to get the updated process exit code, when the process is finished. Signed-off-by: Amador Pahim Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- scripts/qemu.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/qemu.py b/scripts/qemu.py index 880e3e8219..2f1984c93c 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -86,12 +86,12 @@ class QEMUMachine(object): raise def is_running(self): - return self._popen and (self._popen.returncode is None) + return self._popen and (self._popen.poll() is None) def exitcode(self): if self._popen is None: return None - return self._popen.returncode + return self._popen.poll() def get_pid(self): if not self.is_running(): -- 2.13.3