From: Amador Pahim <apahim@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, famz@redhat.com, berrange@redhat.com,
ehabkost@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
armbru@redhat.com, crosa@redhat.com, ldoktor@redhat.com,
Amador Pahim <apahim@redhat.com>
Subject: [Qemu-devel] [PATCH v6 2/7] qemu.py: fix is_running() return before first launch()
Date: Mon, 31 Jul 2017 10:51:05 +0200 [thread overview]
Message-ID: <20170731085110.1050-3-apahim@redhat.com> (raw)
In-Reply-To: <20170731085110.1050-1-apahim@redhat.com>
is_running() returns None when called before the first time we
call launch():
>>> import qemu
>>> vm = qemu.QEMUMachine('qemu-system-x86_64')
>>> vm.is_running()
>>>
It should retunt False instead. This patch fixes that.
Signed-off-by: Amador Pahim <apahim@redhat.com>
---
scripts/qemu.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 2f1984c93c..77565eb092 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -86,7 +86,7 @@ class QEMUMachine(object):
raise
def is_running(self):
- return self._popen and (self._popen.poll() is None)
+ return self._popen is not None and (self._popen.poll() is None)
def exitcode(self):
if self._popen is None:
--
2.13.3
next prev parent reply other threads:[~2017-07-31 8:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 8:51 [Qemu-devel] [PATCH v6 0/7] scripts/qemu.py fixes and cleanups Amador Pahim
2017-07-31 8:51 ` [Qemu-devel] [PATCH v6 1/7] qemu.py: use poll() instead of 'returncode' Amador Pahim
2017-07-31 14:07 ` Eduardo Habkost
2017-07-31 8:51 ` Amador Pahim [this message]
2017-08-01 10:09 ` [Qemu-devel] [PATCH v6 2/7] qemu.py: fix is_running() return before first launch() Stefan Hajnoczi
2017-08-01 10:50 ` Eduardo Habkost
2017-08-01 12:56 ` Amador Pahim
2017-08-02 13:35 ` Stefan Hajnoczi
2017-07-31 8:51 ` [Qemu-devel] [PATCH v6 3/7] qemu.py: use python logging system Amador Pahim
2017-07-31 14:50 ` Eduardo Habkost
2017-07-31 15:05 ` Amador Pahim
2017-08-15 8:10 ` Markus Armbruster
2017-08-15 19:58 ` Eduardo Habkost
2017-08-16 6:17 ` Markus Armbruster
2017-08-18 12:24 ` Amador Pahim
2017-07-31 8:51 ` [Qemu-devel] [PATCH v6 4/7] qemu.py: improve message on negative exit code Amador Pahim
2017-08-15 8:26 ` Markus Armbruster
2017-08-18 12:24 ` Amador Pahim
2017-08-18 13:57 ` Markus Armbruster
2017-08-18 14:33 ` Amador Pahim
2017-07-31 8:51 ` [Qemu-devel] [PATCH v6 5/7] qemu.py: use os.path.null instead of /dev/null Amador Pahim
2017-08-01 10:11 ` Stefan Hajnoczi
2017-08-22 2:24 ` Philippe Mathieu-Daudé
2017-07-31 8:51 ` [Qemu-devel] [PATCH v6 6/7] qemu.py: cleanup and improve launch()/shutdown() Amador Pahim
2017-08-15 8:45 ` Markus Armbruster
2017-07-31 8:51 ` [Qemu-devel] [PATCH v6 7/7] qemu.py: include debug information on launch error Amador Pahim
2017-08-15 8:57 ` Markus Armbruster
2017-08-18 12:42 ` Amador Pahim
2017-08-18 14:01 ` Markus Armbruster
2017-08-18 14:49 ` Amador Pahim
2017-08-21 9:14 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731085110.1050-3-apahim@redhat.com \
--to=apahim@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=ldoktor@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).