Re: [Qemu-devel] [PATCH v2 2/4] trace-events: fix code style: %# -> 0x%

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1335 bytes --]

On Sat, Jul 29, 2017 at 04:11:57PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> In trace format '#' flag of printf is forbidden. Fix it to '0x%'.
> 
> This patch is created by the following:
> 
> check that we have a problem
> > find . -name trace-events | xargs grep '%#' | wc -l
> 56
> 
> check that there are no cases with additional printf flags
> > find . -name trace-events | xargs grep '%[-+ 0]+#' | wc -l
> 0
> 
> check that there are no wrong usage of '#' and '0x' together
> > find . -name trace-events | xargs grep '0x%#' | wc -l
> 0
> 
> fix the problem
> > find . -name trace-events | xargs sed -i 's/%#/0x%/g'
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  audio/trace-events       |  4 ++--
>  block/trace-events       |  6 +++---
>  hw/display/trace-events  |  2 +-
>  hw/i386/xen/trace-events | 22 +++++++++++-----------
>  hw/input/trace-events    |  2 +-
>  hw/intc/trace-events     | 20 ++++++++++----------
>  hw/net/trace-events      | 18 +++++++++---------
>  hw/pci/trace-events      |  4 ++--
>  hw/scsi/trace-events     |  6 +++---
>  hw/xen/trace-events      |  8 ++++----
>  trace-events             | 20 ++++++++++----------
>  11 files changed, 56 insertions(+), 56 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]