From: James Hogan <james.hogan@imgtec.com>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, Yongbok Kim <yongbok.kim@imgtec.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 2/2] mips: Add KVM T&E segment support for TCG
Date: Mon, 31 Jul 2017 22:36:33 +0100 [thread overview]
Message-ID: <20170731213633.GC6973@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <93cb4cb7-842c-1a37-c2dd-a7c522076a1d@twiddle.net>
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
On Mon, Jul 31, 2017 at 01:47:48PM -0700, Richard Henderson wrote:
> On 07/31/2017 06:09 AM, James Hogan wrote:
> > +static int mips_um_ksegs;
> > +
> > uint64_t cpu_mips_kseg0_to_phys(void *opaque, uint64_t addr)
> > {
> > return addr & 0x1fffffffll;
> > @@ -38,3 +40,13 @@ uint64_t cpu_mips_kvm_um_phys_to_kseg0(void *opaque, uint64_t addr)
> > {
> > return addr | 0x40000000ll;
> > }
> > +
> > +int mips_um_ksegs_enabled(void)
>
> bool?
Sure, I'll respin,
>
> Otherwise,
> Reviewed-by: Richard Henderson <rth@twiddle.net>
Thanks for the review!
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-07-31 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 13:09 [Qemu-devel] [PATCH 0/2] mips: KVM T&E segment support for TCG James Hogan
2017-07-31 13:09 ` [Qemu-devel] [PATCH 1/2] mips: Improve segment defs for KVM T&E guests James Hogan
2017-07-31 18:17 ` Philippe Mathieu-Daudé
2017-07-31 13:09 ` [Qemu-devel] [PATCH 2/2] mips: Add KVM T&E segment support for TCG James Hogan
2017-07-31 20:47 ` Richard Henderson
2017-07-31 21:36 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731213633.GC6973@jhogan-linux.le.imgtec.org \
--to=james.hogan@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=yongbok.kim@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).