From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcN9d-0002Wd-A9 for qemu-devel@nongnu.org; Mon, 31 Jul 2017 22:43:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcN9Z-0007hA-Dy for qemu-devel@nongnu.org; Mon, 31 Jul 2017 22:43:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34434) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dcN9Z-0007go-84 for qemu-devel@nongnu.org; Mon, 31 Jul 2017 22:43:25 -0400 Date: Tue, 1 Aug 2017 10:43:19 +0800 From: Peter Xu Message-ID: <20170801024319.GC15697@pxdev.xzpeter.org> References: <1501229198-30588-1-git-send-email-peterx@redhat.com> <1501229198-30588-5-git-send-email-peterx@redhat.com> <20170731171155.GE2122@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170731171155.GE2122@work-vm> Subject: Re: [Qemu-devel] [RFC 04/29] bitmap: introduce bitmap_invert() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org, Laurent Vivier , Alexey Perevalov , Juan Quintela , Andrea Arcangeli On Mon, Jul 31, 2017 at 06:11:56PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (peterx@redhat.com) wrote: > > It is used to invert the whole bitmap. > > Would it be easier to change bitmap_complement to use ^ > in it's macro and slow_bitmap_complement, and then you could call it > with src==dst to do the same thing with just that small change? Or, I can directly use that and drop this patch. :-) (I didn't really notice that one before) Thanks, -- Peter Xu